Skip to content

Port changes from sillsdev/machine.py#336 - #498

Merged
pmachapman merged 1 commit into
masterfrom
port_eflomal_changes
Sep 15, 2026
Merged

pmachapman merged 1 commit into
masterfrom
port_eflomal_changes

Conversation

@pmachapman

@pmachapman pmachapman commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Fixes #487

The only real changes I could see that needed porting from sillsdev/machine.py#336 were in AlignedWordPair.ToString(), and the unit tests for Flatten().


This change is Reviewable

@codecov-commenter

codecov-commenter commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.72%. Comparing base (b42b452) to head (c0942a9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
+ Coverage   73.66%   73.72%   +0.05%     
==========================================
  Files         452      452              
  Lines       37925    37925              
  Branches     5210     5210              
==========================================
+ Hits        27938    27960      +22     
+ Misses       8842     8818      -24     
- Partials     1145     1147       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds right to me. Thanks, Peter!

@Enkidu93 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@pmachapman
pmachapman merged commit 9273cc3 into master Sep 15, 2026
4 checks passed
@pmachapman
pmachapman deleted the port_eflomal_changes branch September 15, 2026 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port 'Use new machine eflomal implementation'

4 participants