Port changes from sillsdev/machine.py#336 - #498
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #498 +/- ##
==========================================
+ Coverage 73.66% 73.72% +0.05%
==========================================
Files 452 452
Lines 37925 37925
Branches 5210 5210
==========================================
+ Hits 27938 27960 +22
+ Misses 8842 8818 -24
- Partials 1145 1147 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ddaspit
approved these changes
Sep 14, 2026
ddaspit
left a comment
Contributor
There was a problem hiding this comment.
@ddaspit reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Enkidu93).
Enkidu93
approved these changes
Sep 14, 2026
Enkidu93
left a comment
Collaborator
There was a problem hiding this comment.
That sounds right to me. Thanks, Peter!
@Enkidu93 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
pmachapman
force-pushed
the
port_eflomal_changes
branch
from
September 15, 2026 00:39
c6f339b to
c0942a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #487
The only real changes I could see that needed porting from sillsdev/machine.py#336 were in
AlignedWordPair.ToString(), and the unit tests forFlatten().This change is