Skip to content

Add TryGetChapters to ScriptureRangeParser - #497

Open
pmachapman wants to merge 2 commits into
masterfrom
scripture_range_parser_updates
Open

pmachapman wants to merge 2 commits into
masterfrom
scripture_range_parser_updates

Conversation

@pmachapman

@pmachapman pmachapman commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Fixes #486

I noticed that the ScriptureRangeParser was not in a namespace, so set the namespace to SIL.Machine.Scripture. If it was not an oversight, I can revert it to remain in the SIL.Machine namespace.

I also took the opportunity to update the unit tests to use new .Net 10 language features.


This change is Reviewable

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.82716% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.53%. Comparing base (418ff22) to head (170f122).

Files with missing lines Patch % Lines
src/SIL.Machine/Scripture/ScriptureRangeParser.cs 94.83% 5 Missing and 3 partials ⚠️
src/SIL.Machine/Corpora/UsxFileTextCorpus.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #497   +/-   ##
=======================================
  Coverage   73.52%   73.53%           
=======================================
  Files         451      451           
  Lines       37697    37708   +11     
  Branches     5183     5183           
=======================================
+ Hits        27718    27728   +10     
- Misses       8841     8842    +1     
  Partials     1138     1138           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a TryGetChapters function to ScriptureRangeParser

3 participants