Add TryGetChapters to ScriptureRangeParser - #497
Open
pmachapman wants to merge 2 commits into
Open
pmachapman wants to merge 2 commits into
pmachapman wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #497 +/- ##
=======================================
Coverage 73.52% 73.53%
=======================================
Files 451 451
Lines 37697 37708 +11
Branches 5183 5183
=======================================
+ Hits 27718 27728 +10
- Misses 8841 8842 +1
Partials 1138 1138 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Enkidu93
approved these changes
Sep 14, 2026
Enkidu93
left a comment
Collaborator
There was a problem hiding this comment.
@Enkidu93 reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ddaspit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #486
I noticed that the ScriptureRangeParser was not in a namespace, so set the namespace to SIL.Machine.Scripture. If it was not an oversight, I can revert it to remain in the SIL.Machine namespace.
I also took the opportunity to update the unit tests to use new .Net 10 language features.
This change is