Fix wrong current user in FW Lite comments for cross-server projects

[myieye]

[Claude, autonomous]

Resolves #2491

Fixes the wrong current user in FW Lite comments when a project's GUID exists on more than one logged-in server (e.g. Sena 3 downloaded from staging but also present on dev): FW Lite offered Edit on other users' comments, hid it on your own, and authored new comments as the wrong user. The same field also drove wrong CRDT commit authorship.

Root cause: ProjectData.LastUserId was written unscoped. Loading the home page enumerates every logged-in server and stamped each server's user onto local projects matched by GUID alone, clobbering the origin server's user.

• Origin-scope the write in CombinedProjectsService: a server only stamps its user/role on projects whose origin is that server.
• Resolve the origin user from the local MSAL cache at project open (no token, no network) so identity is right from the first render; fall back to the persisted value when signed out.
• Attribute synced comment read-status to the freshly resolved user.

[coderabbitai]

📝 Walkthrough

Walkthrough

Changes

Identity and project state

Layer / File(s)	Summary
Cached identity persistence backend/FwLite/FwLiteShared/Auth/OAuthClient.cs, backend/FwLite/FwLiteShared/Services/ProjectServicesProvider.cs, backend/FwLite/LcmCrdt.Tests/CurrentProjectServiceTests.cs, backend/FwLite/FwLiteShared.Tests/Auth/OAuthClientIsSignedInTests.cs, backend/FwLite/FwLiteShared/Sync/SyncService.cs	Adds local cached-user resolution, persists origin-server identity during project opening, tests last-user updates, and uses the authenticated user for sync read-status updates.
Server-origin ownership checks backend/FwLite/FwLiteShared/Projects/CombinedProjectsService.cs, backend/FwLite/FwLiteShared.Tests/Projects/CombinedProjectsServiceTests.cs	Restricts project server-information updates to projects whose stored origin server matches the queried server, with matching and non-matching ownership tests.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: hahn-kev

Poem

I’m a bunny with cached names,
Stamping projects with rightful claims.
Origin servers guard the door,
Sync remembers who logged before.
Tests hop happily—boing, boing!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly matches the main fix: correcting the current user for cross-server FW Lite comments.
Description check	✅ Passed	The description directly explains the bug, root cause, and the implemented fixes reflected in the changeset.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/fw-lite-user-identity-bug-iozg90

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Jul 27, 2026, 4:00 PM
e2e (Inspect)	✅ No changes detected	-	Jul 27, 2026, 4:07 PM

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@backend/FwLite/FwLiteShared/Auth/OAuthClient.cs`:
- Around line 201-205: Update GetCachedUser() to select the cached MSAL account
whose HomeAccountId.Environment matches the configured project origin server or
authority, instead of using FirstOrDefault() across all accounts. Preserve the
existing null handling and LexboxUser construction after selecting the matching
account.

In `@backend/FwLite/FwLiteShared/Services/ProjectServicesProvider.cs`:
- Around line 87-100: The ResolveOriginUser method must tolerate expected MSAL
cache/account-read failures from GetCachedUser so OpenCrdtProject can still
create the project scope. Catch the relevant exception around the cached-user
lookup, return the original projectData unchanged on failure, and add coverage
for this failure path while preserving the existing null-user behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e9294d87-7d22-4c37-a7ed-29e2be2c38c5

📥 Commits

Reviewing files that changed from the base of the PR and between 819ae99 and 05fe964.

📒 Files selected for processing (7)

• backend/FwLite/FwLiteShared.Tests/Auth/OAuthClientIsSignedInTests.cs
• backend/FwLite/FwLiteShared.Tests/Projects/CombinedProjectsServiceTests.cs
• backend/FwLite/FwLiteShared/Auth/OAuthClient.cs
• backend/FwLite/FwLiteShared/Projects/CombinedProjectsService.cs
• backend/FwLite/FwLiteShared/Services/ProjectServicesProvider.cs
• backend/FwLite/FwLiteShared/Sync/SyncService.cs
• backend/FwLite/LcmCrdt.Tests/CurrentProjectServiceTests.cs