Remove CRDT morph-type migrate seeding - #2483
Conversation
Closes #2350. Co-authored-by: Cursor <cursoragent@cursor.com>
📝 WalkthroughWalkthroughMorph-type seeding was removed from database migration paths, test fixtures now seed or validate project states explicitly, and ChangesMorph-type lifecycle
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
I opened #2492 as what I think is the best fix for the failing test. By making the dry run sync actually work in both directions it doesn't try to delete morph-types on the fwdata side. |
Closes #2350
I also decided that we could pretty easily shim in the canonical morph types in the JsInvokable api if there are none in the project as a sort of safety net.
AI summary
Summary
PreDefinedData; seed morph types explicitly inMiniLcmApiFixturevia oneAddChangesbatchMiniLcmJsInvokable.GetMorphTypes()returns canonical morph-type copies when the underlying API returns noneTest plan
dotnet test backend/FwLite/FwLiteShared.Tests --filter FullyQualifiedName~MiniLcmJsInvokableMorphTypeFallbackdotnet test backend/FwLite/LcmCrdt.Tests --filter FullyQualifiedName~MorphTypedotnet test backend/FwLite/LcmCrdt.Tests --filter "FullyQualifiedName~DownloadProjectTests|FullyQualifiedName~OpenProjectTests|FullyQualifiedName~MigrationTests.GetEntries"