Activity redesign part 2: render writing-system codes as monospace chips - #2475
Activity redesign part 2: render writing-system codes as monospace chips#2475myieye wants to merge 4 commits into
Conversation
Extracts a WsCode component and uses it in the editor's multi-writing-system field labels and the dictionary preview (which opts out of the chip chrome via plain). Chip text uses foreground/60 to clear WCAG AA on the muted fill. This gives live editor fields visual parity with the read-only diff views that later parts of the activity redesign introduce (part 2/6, assembled result reviewed in #2434). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vm9mEUzcfgX4oUPAbhcfsj
📝 WalkthroughWalkthroughAdds a reusable ChangesWriting-system code rendering
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
The editor chip is a field's writing-system label, where a misread means data entered under the wrong writing system. foreground/60 (kept for the read-only dictionary/activity preview, where the code is a passive annotation) was too faint for that; the chip now runs full contrast in both themes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
foreground/60 was the lightest grey that merely cleared AA (~5:1); the reader still parses these codes to tell which writing system each gloss is, so /75 (~9:1) reads comfortably while staying clearly subordinate to the value text. Editor chip is unaffected (full contrast). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Monospace renders ~one size step smaller than the app's sans, so font-mono text-xs sat ~23% below the text-xs-sans label floor the chip replaced. text-sm mono matches that floor (and the old <Label>'s size). The plain form stays text-xs to recede inline beside the gloss. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@hahn-kev This could be a self review, but changing the ws-code labels feels significant, so please see if you like them. |
|
Yeah, I almost want to get input from Sara on this one actually. |
|
I think I'm just going to forget about this actually. I'm just gonna focus on making the activity view look the way we want it. |
[Claude, autonomous]
Render writing-system codes as monospace chips via a new
WsCodecomponent: a borderedchipfor the editor's multi-writing-system field labels (multi-ws-input,rich-multi-ws-input) and a chrome-lessplainvariant in the dictionary preview. Part 2/8 of the activity redesign; follows #2435.Groundwork for rendering writing-system codes in the activity-item summaries later in the series. The monospace treatment came from a UX reviewer's suggestion that the codes should read more like codes.
Chip text uses
text-foreground/60(nottext-muted-foreground) to clear WCAG AA on the muted fill at 12px.Screenshots
All-writing-systems demo entry (
!nyumba); click to enlarge.