Silence compiler warning about AddRangeAsync - #2447
Conversation
The dotnet compiler warns that we should use AddRangeAsync here, but the EF Core documentation expicitly says that AddRangeAsync is only for use in special value generators, and all other uses should use AddRange. So we silence the compiler warning and still use AddRange.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesUnread comment status
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
Argos changes look like a false positive. There was a transient failure on one other check, so I'm waiting for the rerun to complete, then I'll merge. |
The dotnet compiler warns about some code added by #2382, saying that we should use AddRangeAsync rather than AddRange because it's in an async method. But the EF Core documentation expicitly says that AddRangeAsync is only for use in special value generators, and all other uses should use AddRange. So we silence the compiler warning and still use AddRange.