Activity redesign: responsive split view, failure containment, review hardening (follow-on to #2388)

backend/FwLite/FwLiteShared/Services/HistoryServiceJsInvokable.cs

@@ -14,15 +14,15 @@ public Task<IObjectWithId> GetObject(Guid commitId, Guid entityId)
     }
 
     [JSInvokable]
-    public async ValueTask<ProjectActivity[]> ProjectActivity(
+    public Task<ProjectActivity[]> ProjectActivity(
         int skip,
         int take,
         string[]? authorFilterKeys = null,
         string[]? changeTypeKeys = null,
         ActivitySort sort = ActivitySort.NewestFirst)
     {
-        return await historyService.ProjectActivity(skip, take,
-            new ActivityQuery(authorFilterKeys, changeTypeKeys, sort)).ToArrayAsync();
+        return historyService.ProjectActivity(skip, take,
+            new ActivityQuery(authorFilterKeys, changeTypeKeys, sort));
     }
 
     [JSInvokable]

backend/FwLite/FwLiteShared/TypeGen/ChangeTypesCodeGenerator.cs

@@ -0,0 +1,33 @@
+using LcmCrdt;
+using Reinforced.Typings;
+using Reinforced.Typings.Ast;
+using Reinforced.Typings.Generators;
+
+namespace FwLiteShared.TypeGen;
+
+/// <summary>
+/// Emits a `ChangeType` string-literal union and a `knownChangeTypes` array built from the registered CRDT
+/// change types (<see cref="LcmCrdtKernel.AllChangeTypes"/>) and each type's serialized <c>$type</c>
+/// discriminator (<see cref="HistoryService.GetChangeTypeKeyFromType"/>). Attached to the <c>ChangeTypes</c>
+/// marker; suppresses the marker's own output.
+/// </summary>
+public class ChangeTypesCodeGenerator : ClassCodeGenerator
+{
+    public override RtClass GenerateNode(Type element, RtClass result, TypeResolver resolver)
+    {
+        var typeNames = LcmCrdtKernel.AllChangeTypes()
+            .Select(HistoryService.GetChangeTypeKeyFromType)
+            .Distinct()
+            .OrderBy(name => name, StringComparer.Ordinal)
+            .ToArray();
+
+        var union = string.Concat(typeNames.Select(name => $"\n  | '{name}'"));
+        var array = string.Concat(typeNames.Select(name => $"\n  '{name}',"));
+
+        Context.Location.CurrentNamespace.CompilationUnits.Add(new RtRaw(
+            $"export type ChangeType ={union};\n\nexport const knownChangeTypes = [{array}\n] as const satisfies readonly ChangeType[];\n"));
+
+        // Suppress the marker class; only the raw union/array above is emitted.
+        return null!;
+    }
+}

backend/FwLite/FwLiteShared/TypeGen/ChangeTypesMarker.cs

@@ -0,0 +1,10 @@
+// Namespace is LcmCrdt (not FwLiteShared.TypeGen) on purpose: Reinforced.Typings derives the generated
+// file's path from the type's namespace, so this keeps the output at generated-types/LcmCrdt/ChangeTypes.ts.
+namespace LcmCrdt;
+
+/// <summary>
+/// Marker type only — no members. Reinforced.Typings (via <c>ChangeTypesCodeGenerator</c>) emits the
+/// <c>ChangeType</c> string-literal union and <c>knownChangeTypes</c> array into ChangeTypes.ts from the
+/// registered change types, so the frontend has a generated, exhaustive list of change <c>$type</c> values.
+/// </summary>
+internal sealed class ChangeTypes;

backend/FwLite/FwLiteShared/TypeGen/ReinforcedFwLiteTypingConfig.cs

@@ -183,6 +183,7 @@ private static void ConfigureFwLiteSharedTypes(ConfigurationBuilder builder)
             typeof(FwLiteConfig),
             typeof(HistoryLineItem),
             typeof(ProjectActivity),
+            typeof(ActivityChangeInfo),
             typeof(ActivityAuthor),
             typeof(ActivityChangeType),
             typeof(ActivityQuery),
@@ -196,6 +197,8 @@ private static void ConfigureFwLiteSharedTypes(ConfigurationBuilder builder)
             typeof(AvailableUpdate),
         ], exportBuilder => exportBuilder.WithPublicProperties());
 
+        builder.ExportAsClass<ChangeTypes>().WithCodeGenerator<ChangeTypesCodeGenerator>();
+
         builder.ExportAsEnum<ActivitySort>().UseString();
         builder.ExportAsEnum<FwEventType>().UseString();
         builder.ExportAsEnum<LogLevel>().UseString(false);

backend/FwLite/LcmCrdt.Tests/DateTimeOffsetOrmParityTests.cs

@@ -48,7 +48,7 @@ public async Task CommitTimestamp_SameUtcInstant_ThroughEfCoreAndLinq2db()
         // switches to EF this keeps the linq2db path (the one that needed the fix) under test.
         var l2dbTimestamp = await ctx.Set<Commit>().Where(c => c.Id == commit.Id)
             .ToLinqToDB().Select(c => c.HybridDateTime.DateTime).FirstAsyncLinqToDB();
-        var activityTimestamp = (await History.ProjectActivity(0, 1000).ToArrayAsync()).First(a => a.CommitId == commit.Id).Timestamp;
+        var activityTimestamp = (await History.ProjectActivity(0, 1000)).First(a => a.CommitId == commit.Id).Timestamp;
         var historyTimestamp = (await History.GetHistory(entryId).ToArrayAsync()).First(h => h.CommitId == commit.Id).Timestamp;
 
         foreach (var (name, value) in new[]

backend/FwLite/LcmCrdt.Tests/OpenProjectTests.cs

@@ -123,7 +123,7 @@ await WithProjectFromTemplate(request, "fr", async (services, api) =>
             var historyService = services.GetRequiredService<HistoryService>();
 
             // The imported template data is re-attributed to System and tagged, overriding the signed-in user.
-            var templateCommits = await historyService.ProjectActivity(0, 1000, new ActivityQuery()).ToArrayAsync();
+            var templateCommits = await historyService.ProjectActivity(0, 1000, new ActivityQuery());
             templateCommits.Should().NotBeEmpty();
             templateCommits.Should().AllSatisfy(activity =>
             {
@@ -134,7 +134,7 @@ await WithProjectFromTemplate(request, "fr", async (services, api) =>
 
             // A later edit keeps the signed-in user (not System) — the stamp is scoped to the template import.
             await api.CreateEntry(new() { LexemeForm = { ["fr"] = "post-template" } });
-            var latest = (await historyService.ProjectActivity(0, 1, new ActivityQuery()).ToArrayAsync()).Single();
+            var latest = (await historyService.ProjectActivity(0, 1, new ActivityQuery())).Single();
             latest.Metadata.AuthorId.Should().Be("test-user-id");
             latest.Metadata.AuthorName.Should().Be("Test User");
             latest.Metadata[CommitHelpers.TemplateProp].Should().BeNull();
@@ -167,7 +167,7 @@ await WithProjectFromTemplate(request, "fr", async (services, api) =>
 
     private static async Task<string?> LatestCommitAuthorId(HistoryService historyService)
     {
-        var latest = await historyService.ProjectActivity(skip: 0, take: 1).ToArrayAsync();
+        var latest = await historyService.ProjectActivity(skip: 0, take: 1);
         return latest.Single().Metadata.AuthorId;
     }