Remove dead internal code from L10NSharp.Windows.Forms - #168
Open
imnasnainaec wants to merge 2 commits into
Open
Remove dead internal code from L10NSharp.Windows.Forms#168imnasnainaec wants to merge 2 commits into
imnasnainaec wants to merge 2 commits into
Conversation
NodeComparer, UtilsWinforms, InitializationProgressDlg and InitializationProgressDlgBase are internal and unreferenced anywhere in the solution; the two dialogs referenced only each other. Removing them is not an API change, since none of them were public. The unreferenced public types in UIComponents (LanguageChoosingSimpleDialog, UILanguageListBox, FallbackLanguagesDlg and FallbackLanguagesDlgBase) are deliberately left in place: dropping them would be a breaking change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
imnasnainaec
marked this pull request as ready for review
September 9, 2026 12:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes four
internaltypes inL10NSharp.Windows.Formsthat are unreferenced anywhere in the solution.NodeComparer<T>internal, zero referencesUtilsWinformsinternal, zero referencesInitializationProgressDlg<T>internal, referenced only by its baseInitializationProgressDlgBase(+.Designer.cs,.resx)internal, referenced only by the aboveAlso drops the two now-orphaned
<Compile Update>entries fromL10NSharp.Windows.Forms.csproj.Since none of these were public, this is not an API change, so the commit carries no
+semvermarker.🤖 Generated with Claude Code
Devin review: https://app.devin.ai/review/sillsdev/l10nsharp/pull/168
This change is