Skip to content

Add comment-rules skill for TypeScript authoring - #177

Merged
jasonleenaylor merged 2 commits into
mainfrom
chore/comment-rules-skill
Jul 28, 2026
Merged

Add comment-rules skill for TypeScript authoring#177
jasonleenaylor merged 2 commits into
mainfrom
chore/comment-rules-skill

Conversation

@jasonleenaylor

@jasonleenaylor jasonleenaylor commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Guides doc/inline comments toward why-focused brevity; tracks .claude/skills/ so repo skills are versioned.


This change is Reviewable

Summary by CodeRabbit

  • Documentation

    • Added centralized TypeScript comment/JSDoc-writing guidelines, including rules for documenting exports vs internal symbols, when to use @param, @returns, and @throws, and permitted reference formatting.
    • Updated agents documentation to point to the centralized comment policy.
  • Chores

    • Updated repository ignore rules to exclude all .claude/ content while ensuring the tracked skill documentation remains included.

Guides doc/inline comments toward why-focused brevity; tracks .claude/skills/ so repo skills are versioned.
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jasonleenaylor, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d971c85f-9fa6-45dd-a957-6abf51d1929b

📥 Commits

Reviewing files that changed from the base of the PR and between 834fb72 and 542985b.

📒 Files selected for processing (2)
  • .claude/skills/comment-rules/SKILL.md
  • AGENTS.md
📝 Walkthrough

Walkthrough

Adds centralized TypeScript comment-writing guidelines, updates AGENTS.md to reference them, and adjusts .gitignore so .claude/skills/ remains tracked.

Changes

Comment Rules

Layer / File(s) Summary
Comment guidance and repository wiring
.claude/skills/comment-rules/SKILL.md, AGENTS.md, .gitignore
Defines TypeScript documentation and inline comment rules, centralizes the repository directive, and updates ignore patterns to track the skills directory.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding a TypeScript comment-rules skill.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/comment-rules-skill

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alex-rawlings-yyc alex-rawlings-yyc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. I will defer to @imnasnainaec to approve so he can give his two cents before this is merged. Though now that I've written this out, I realize that it may be good to mention the skill in AGENTS.md

@alex-rawlings-yyc reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on jasonleenaylor).

@imnasnainaec imnasnainaec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imnasnainaec reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on jasonleenaylor).


.claude/skills/comment-rules/SKILL.md line 19 at r1 (raw file):

- Exported methods, classes, interfaces, types, and constants: give a short summary.
- Private/internal symbols: comment only when the purpose is non-obvious. Skip trivial getters, thin wrappers, and self-evident helpers.

We have a stronger statement of full required docs on all functions in the AGENTS.md file, so this and that need to be harmonized. Same as with params/returns below.

@alex-rawlings-yyc alex-rawlings-yyc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll defer to @imnasnainaec for approval again

@alex-rawlings-yyc reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on jasonleenaylor).

@jasonleenaylor
jasonleenaylor enabled auto-merge (squash) July 28, 2026 18:54

@imnasnainaec imnasnainaec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imnasnainaec reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on jasonleenaylor).


.claude/skills/comment-rules/SKILL.md line 27 at r2 (raw file):
⛏️ There's some risk of ambiguity/confusion with the final sentence of this paragraph. How about changing

If any parameter deserves a comment, document all of them.

to something like

An exception: if any single method parameter deserves a comment, document all the parameters of that method.

@jasonleenaylor
jasonleenaylor force-pushed the chore/comment-rules-skill branch from a9af4b6 to 834fb72 Compare July 28, 2026 19:49
Migrate JSDoc rules from AGENTS.md into the skill; require all params documented if any is; use ASCII only.
@jasonleenaylor
jasonleenaylor force-pushed the chore/comment-rules-skill branch from 834fb72 to 542985b Compare July 28, 2026 20:02

@imnasnainaec imnasnainaec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imnasnainaec reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on jasonleenaylor).

@jasonleenaylor
jasonleenaylor merged commit 54346dd into main Jul 28, 2026
10 checks passed
@jasonleenaylor
jasonleenaylor deleted the chore/comment-rules-skill branch July 28, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants