Add comment-rules skill for TypeScript authoring - #177
Conversation
Guides doc/inline comments toward why-focused brevity; tracks .claude/skills/ so repo skills are versioned.
|
Warning Review limit reached
Next review available in: 46 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds centralized TypeScript comment-writing guidelines, updates ChangesComment Rules
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alex-rawlings-yyc
left a comment
There was a problem hiding this comment.
This all looks good to me. I will defer to @imnasnainaec to approve so he can give his two cents before this is merged. Though now that I've written this out, I realize that it may be good to mention the skill in AGENTS.md
@alex-rawlings-yyc reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jasonleenaylor).
imnasnainaec
left a comment
There was a problem hiding this comment.
@imnasnainaec reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on jasonleenaylor).
.claude/skills/comment-rules/SKILL.md line 19 at r1 (raw file):
- Exported methods, classes, interfaces, types, and constants: give a short summary. - Private/internal symbols: comment only when the purpose is non-obvious. Skip trivial getters, thin wrappers, and self-evident helpers.
We have a stronger statement of full required docs on all functions in the AGENTS.md file, so this and that need to be harmonized. Same as with params/returns below.
alex-rawlings-yyc
left a comment
There was a problem hiding this comment.
Looks good to me! I'll defer to @imnasnainaec for approval again
@alex-rawlings-yyc reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on jasonleenaylor).
imnasnainaec
left a comment
There was a problem hiding this comment.
@imnasnainaec reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on jasonleenaylor).
.claude/skills/comment-rules/SKILL.md line 27 at r2 (raw file):
⛏️ There's some risk of ambiguity/confusion with the final sentence of this paragraph. How about changing
If any parameter deserves a comment, document all of them.
to something like
An exception: if any single method parameter deserves a comment, document all the parameters of that method.
a9af4b6 to
834fb72
Compare
Migrate JSDoc rules from AGENTS.md into the skill; require all params documented if any is; use ASCII only.
834fb72 to
542985b
Compare
imnasnainaec
left a comment
There was a problem hiding this comment.
@imnasnainaec reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jasonleenaylor).
Guides doc/inline comments toward why-focused brevity; tracks .claude/skills/ so repo skills are versioned.
This change is
Summary by CodeRabbit
Documentation
@param,@returns, and@throws, and permitted reference formatting.Chores
.claude/content while ensuring the tracked skill documentation remains included.