Skip to content

Implement fail-fast mechanism for prompt_worker (prevent “accept but not execute”) #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lixiangcog wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement fail-fast mechanism for prompt_worker (prevent “accept but not execute”) #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,14 @@ def setup_database():
logging.error(f"Failed to initialize database. Please ensure you have installed the latest requirements. If the error persists, please report this as in future the database will be required: {e}")


def prompt_worker_failfast(*args, **kwargs):
try:
return prompt_worker(*args, **kwargs)
except Exception:
logging.critical("Unhandled exception in prompt_worker; exiting process.", exc_info=True)
os._exit(1)


def start_comfyui(asyncio_loop=None):
"""
Starts the ComfyUI server using the provided asyncio event loop or creates a new one.
Expand Down Expand Up @@ -367,7 +375,7 @@ def start_comfyui(asyncio_loop=None):
prompt_server.add_routes()
hijack_progress(prompt_server)

threading.Thread(target=prompt_worker, daemon=True, args=(prompt_server.prompt_queue, prompt_server,)).start()
threading.Thread(target=prompt_worker_failfast, daemon=True, args=(prompt_server.prompt_queue, prompt_server,)).start()

if args.quick_test_for_ci:
exit(0)
Expand Down