Change the syslog module to use slog-syslog@0.13.#37
Closed
argv-minus-one wants to merge 2 commits into
Closed
Conversation
Owner
|
Thanks! I'm looking forward to this PR gets ready for merge. |
Closed
…` and enables control of syslog priorities on a per-message basis. Thanks to @eun-ice for the idea and initial implementation.
Contributor
Author
|
Sorry, I forgot all about this! Unfortunately I'm no longer using slog, so I'm going to go ahead and close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dpc asked me to contribute the code I wrote for
sloggers::syslogto use as a new version of theslog-syslogcrate, so I've submitted that code in slog-rs/syslog#6. I also changed it to write log messages into a thread-local reusable buffer, so it should be faster than the currentsloggers::syslogimplementation.This PR changes
sloggers::syslogto use that newslog-syslogcrate.I'm marking this PR as a draft because slog-rs/syslog#6 has not yet been merged.