Created fetch-airlines.js - #3
Open
olejorga wants to merge 3 commits into
Open
Conversation
Member
|
Cool... I'll review this later today. Also we'd need some tests around this. |
MichalCz
requested changes
Feb 17, 2020
MichalCz
left a comment
MichalCz
left a comment
Member
There was a problem hiding this comment.
Ok, so now we need a getter and an index file something like: openflights-cached/index.js but for airlines.
Or simply add another getter to self in index. Also findAirline(id) would be good so it would need a similar code like index.js:10: requireicao and the getter around line 25.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fetches airline data and structures it like airports in dist/airlines for now.
I also added a way of getting rid of bad icao and iata codes in the source data.