Updated to version 1.15.0 - #20
Merged
Merged
Conversation
btsouts
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new cross-check to ensure that every Ux string recorded in a tracing database is also printed to stdout, and refactors the Ux string comparison logic to operate directly on stdout output rather than on tracing databases. This change improves the reliability of benchmarking, especially when comparing optimized (
-O2) and unoptimized (-O0) builds, and ensures that the verification process is not undermined by build configuration constraints. The update also adds comprehensive tests for the new check and clarifies documentation to reflect the new approach.New Ux string cross-check and testing:
check_traced_values_printed.py, a module that verifies all Ux strings recorded during a tracing run are also present in the run's stdout, with detailed reporting and robust error handling.check_traced_values_printed_test.py, providing unit tests for the new cross-check logic to ensure correctness and reliability.Refactoring and documentation updates:
compare_tracing_ux_strings.pyto compare Ux strings printed to stdout instead of reading from tracing databases, updating logic, reporting, and documentation to match the new approach.README.mdto clarify that the-O2verification now compares Ux strings from stdout, not from a tracing database, and explains the rationale and implications for verification.