Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion src/github3/users.py
Original file line number Diff line number Diff line change
Expand Up @@ -971,7 +971,31 @@ class Contributor(_User):
_refresh_to = User

def _update_attributes(self, contributor):
super()._update_attributes(contributor)
if "login" in contributor:
super()._update_attributes(contributor)
self.name = contributor.get("name")
self.email = contributor.get("email")
else:
self.avatar_url = None
self.events_urlt = None
self.followers_url = None
self.following_urlt = None
self.gists_urlt = None
self.gravatar_id = None
self.html_url = None
self.id = None
self.login = contributor.get("name") or contributor.get("email")
self.name = contributor.get("name")
self.email = contributor.get("email")
self.organizations_url = None
self.received_events_url = None
self.repos_url = None
self.site_admin = None
self.starred_urlt = None
self.subscriptions_url = None
self.type = None
self.url = self._api = None
self._uniq = self.login
self.contributions_count = contributor["contributions"]


Expand Down
24 changes: 24 additions & 0 deletions tests/unit/test_users.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,30 @@ def test_str(self):
assert repr(self.instance) == "<User [ghost:Deleted user]>"


class TestContributor(helper.UnitHelper):
"""Test methods on Contributor class."""

described_class = github3.users.Contributor
example_data = dict(get_users_example_data(), contributions=1)

def test_anonymous_contributor(self):
"""Show that anonymous contributors are parsed."""
contributor = github3.users.Contributor(
{
"name": "Anonymous Contributor",
"email": "anonymous@example.com",
"contributions": 3,
},
self.session,
)

assert contributor.name == "Anonymous Contributor"
assert contributor.email == "anonymous@example.com"
assert contributor.login == "Anonymous Contributor"
assert contributor.contributions_count == 3
assert contributor.url is None


class TestUserGPGKeyRequiresAuth(helper.UnitRequiresAuthenticationHelper):
"""Unit tests that demonstrate which GPGKey methods require auth."""

Expand Down