-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Deepak/path filter include #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
ba38924
ecbbcab
6a97ee2
60bd17b
33a923c
a9c2cca
7e85f98
b662930
b3f3ca4
d5890cc
86b4fb1
1ddaf9a
a2c1890
2a50aeb
5d6c41a
8369452
c70c5bc
f595e09
81cc592
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /home/deepak/Projects/devops-directive-github-actions-course/.devbox/virtenv/poetry/bin/initHook.sh |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /home/deepak/Projects/devops-directive-github-actions-course/.devbox/virtenv/python312/bin/venvShellHook.sh |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #!/bin/sh | ||
|
|
||
| poetry env use $(command -v python) --directory="${DEVBOX_PYPROJECT_DIR:-$DEVBOX_DEFAULT_PYPROJECT_DIR}" --no-interaction --quiet >&2 | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,55 @@ | ||||||||||||||||||||||||||||||
| #!/bin/sh | ||||||||||||||||||||||||||||||
| set -eu | ||||||||||||||||||||||||||||||
| STATE_FILE="$DEVBOX_PROJECT_ROOT/.devbox/venv_check_completed" | ||||||||||||||||||||||||||||||
|
Comment on lines
+1
to
+3
|
||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| is_valid_venv() { | ||||||||||||||||||||||||||||||
| [ -f "$1/bin/activate" ] && [ -f "$1/bin/python" ] | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| is_devbox_venv() { | ||||||||||||||||||||||||||||||
| [ "$1/bin/python" -ef "$DEVBOX_PACKAGES_DIR/bin/python" ] | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| create_venv() { | ||||||||||||||||||||||||||||||
| python -m venv "$VENV_DIR" --clear | ||||||||||||||||||||||||||||||
| echo "*\n.*" >> "$VENV_DIR/.gitignore" | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
| echo "*\n.*" >> "$VENV_DIR/.gitignore" | |
| printf '%s\n' '*' '.*' > "$VENV_DIR/.gitignore" |
Copilot
AI
Apr 17, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hook prompts with read reply when the venv isn’t a Devbox venv. If this hook runs in a non-interactive context (e.g., devbox run / CI), it will block indefinitely. Consider detecting non-interactive stdin (or honoring an env var default) and failing fast or choosing a safe default behavior.
| echo "Do you want to overwrite it? (y/n)" | |
| read reply | |
| echo | |
| if [ "${DEVBOX_VENV_OVERWRITE:-}" != "" ]; then | |
| reply="$DEVBOX_VENV_OVERWRITE" | |
| elif [ -t 0 ]; then | |
| echo "Do you want to overwrite it? (y/n)" | |
| read reply | |
| echo | |
| else | |
| echo "ERROR: Non-interactive shell cannot prompt to overwrite $VENV_DIR." | |
| echo "Set DEVBOX_VENV_OVERWRITE=y to overwrite it, or DEVBOX_VENV_OVERWRITE=n to keep it." | |
| exit 1 | |
| fi |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -5,11 +5,14 @@ on: | |||||
| jobs: | ||||||
| job-1: | ||||||
| runs-on: ubuntu-24.04 | ||||||
| needs: | ||||||
|
||||||
| needs: | |
| needs: |
Copilot
AI
Apr 17, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in the inline comment: realtion should be relation.
Copilot
AI
Apr 17, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
job-5 is described as “independent”/able to run in parallel, but job-1 and job-3 now both need job-5, which makes it a prerequisite and changes the DAG/parallelism. Either drop the needs: [job-5] dependencies (if the goal is parallelism) or update the job description/comments to match the intended dependency behavior.
Copilot
AI
Apr 17, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in the inline comment: realtion should be relation.
Copilot
AI
Apr 17, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There’s trailing whitespace after the job id key (job-6: ). Removing it avoids whitespace-only diffs and potential YAML lint failures.
| job-6: | |
| job-6: |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -24,7 +24,7 @@ on: | |||||
|
|
||||||
| ### https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#schedule | ||||||
| # schedule: | ||||||
| # - cron: "0 0 * * *" # Midnight UTC | ||||||
| # - cron: "0 0 * * *" # Midnight UTC | ||||||
|
||||||
| # - cron: "0 0 * * *" # Midnight UTC | |
| # - cron: "0 0 * * *" # Midnight UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--directory=...is a Poetry global option and typically must appear before the subcommand (e.g.,poetry --directory ... env use ...). As written,poetry env use ... --directory=...may be ignored or error depending on Poetry version. Reorder the command to ensure it consistently targets the intended pyproject directory.