Skip to content

feat(sql-escaper): add Temporal support when escaping values - #4392

Merged
wellwelwel merged 1 commit into
sidorares:masterfrom
pdeveltere:feat/bump-sql-escaper-1.5.0
Jul 13, 2026
Merged

feat(sql-escaper): add Temporal support when escaping values#4392
wellwelwel merged 1 commit into
sidorares:masterfrom
pdeveltere:feat/bump-sql-escaper-1.5.0

Conversation

@pdeveltere

@pdeveltere pdeveltere commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Bumps the direct sql-escaper dependency from ^1.4.0 to ^1.5.1.

sql-escaper 1.5.x adds Temporal API support when escaping values (Temporal.Instant, PlainDate, PlainTime, PlainDateTime, ZonedDateTime), detected via Object.prototype.toString so no newer runtime is required.

As discussed in #4216, the range ^1.4.0 already permits these on fresh installs, but existing installations won't pick them up without this bump. Releasing as a feat: forces the update to reach all users on npm update.

^1.5.1 (not 1.5.0): 1.5.0's emitted types referenced the global Temporal namespace, which broke tsc for any consumer without the ESNext.Temporal lib (TypeScript < 7) — including this repo's own typecheck. Fixed in mysqljs/sql-escaper#49, released as 1.5.1.

Refs #4216

@wellwelwel wellwelwel changed the title feat: bump sql-escaper to ^1.5.0 feat(sql-escaper): add Temporal support when escaping values Jul 12, 2026
@wellwelwel wellwelwel linked an issue Jul 12, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.52%. Comparing base (457c316) to head (361667c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4392   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files          91       91           
  Lines       14768    14768           
  Branches     1948     1948           
=======================================
  Hits        13516    13516           
  Misses       1252     1252           
Flag Coverage Δ
compression-0 90.80% <ø> (ø)
compression-1 91.50% <ø> (ø)
static-parser-0 90.38% <ø> (ø)
static-parser-1 90.62% <ø> (ø)
tls-0 91.05% <ø> (ø)
tls-1 91.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pdeveltere

Copy link
Copy Markdown
Contributor Author

Marking as draft: this bump surfaces TS2503: Cannot find namespace 'Temporal' downstream because sql-escaper 1.5.0's emitted types reference the global Temporal namespace (needs the ESNext.Temporal lib, TypeScript 7 only). Fix opened upstream in mysqljs/sql-escaper#49. Once that releases (1.5.1), I'll bump this to ^1.5.1 and mark ready.

@wellwelwel

Copy link
Copy Markdown
Collaborator

Marking as draft: this bump surfaces TS2503: Cannot find namespace 'Temporal' downstream because sql-escaper 1.5.0's emitted types reference the global Temporal namespace (needs the ESNext.Temporal lib, TypeScript 7 only). Fix opened upstream in mysqljs/sql-escaper#49. Once that releases (1.5.1), I'll bump this to ^1.5.1 and mark ready.

1.5.1 already released 🙋🏻‍♂️

sql-escaper v1.5.x adds Temporal API support (Temporal.Instant,
PlainDate, PlainTime, PlainDateTime, ZonedDateTime) when escaping
values. Bumping the direct dependency ensures existing installations
pick up the support on `npm update` rather than only on fresh installs.

1.5.1 is required: 1.5.0's emitted types referenced the global Temporal
namespace, breaking `tsc` for consumers without the ESNext.Temporal lib
(fixed in mysqljs/sql-escaper#49).

Refs sidorares#4216

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@pdeveltere
pdeveltere force-pushed the feat/bump-sql-escaper-1.5.0 branch from 728f7d1 to 361667c Compare July 12, 2026 21:50
@pdeveltere pdeveltere changed the title feat(sql-escaper): add Temporal support when escaping values feat: bump sql-escaper to ^1.5.1 Jul 12, 2026
@pdeveltere
pdeveltere marked this pull request as ready for review July 12, 2026 21:50
@pdeveltere

pdeveltere commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

Bumped to ^1.5.1 👍🏼

@wellwelwel wellwelwel changed the title feat: bump sql-escaper to ^1.5.1 feat(sql-escaper): add Temporal support when escaping values Jul 13, 2026
@wellwelwel
wellwelwel merged commit 6b933f6 into sidorares:master Jul 13, 2026
104 checks passed
@pdeveltere
pdeveltere deleted the feat/bump-sql-escaper-1.5.0 branch July 14, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Temporal API support

2 participants