Fix ORDER BY with named aggregates that expand to subqueries#34
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28.
When an expanded AGGREGATE ... AT SELECT alias contains a scalar subquery, DuckDB can order by the alias directly but fails when that alias is referenced inside a complex ORDER BY expression such as revenue / year_total.
This rewrites those complex ORDER BY expressions through the DuckDB parser by inlining SELECT aliases only when the expression references a subquery-backed alias. Simple ORDER BY year_total and qualified tie-breakers stay in the original query scope.
Tests added for the original ratio sort, qualified tie-breakers, and simple alias ordering.