Add Rust standalone runtime baseline#145
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eed1b7140d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cargo test --features workbench-tui --bin sidemantic workbench | ||
| cargo test --features workbench-adbc --bin sidemantic workbench |
There was a problem hiding this comment.
These commands currently don't execute the intended workbench smoke coverage in sidemantic-rs/tests/cli_smoke.rs. I checked cargo test --help, which states --bin [<NAME>] will "Test only the specified binary"; combined with the trailing workbench filter, this only searches unit tests in the sidemantic binary target and skips integration test targets. As a result, regressions in workbench CLI behavior under workbench-tui / workbench-adbc features can pass CI unnoticed unless the tests are invoked with --test ... (or --tests) for those feature combinations.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86d68b9017
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if target_dialect != self.dialect: | ||
| import sqlglot | ||
|
|
||
| sql = sqlglot.transpile(sql, read=self.dialect, write=target_dialect)[0] |
There was a problem hiding this comment.
_compile_with_rust assumes no transpilation is needed when target_dialect == self.dialect, but the Rust path currently emits SQL in its own default style (e.g., runtime compile goes through SqlGenerator::new(...) without a dialect override). For non-DuckDB layers (Postgres/BigQuery/etc.), this branch returns DuckDB-flavored SQL unchanged, and even when transpilation runs it uses read=self.dialect instead of the Rust output dialect. In strict mode or with SIDEMANTIC_RS_SQL_GENERATOR_VERIFY=0, this can send invalid SQL to the adapter and fail user queries.
Useful? React with 👍 / 👎.
1 participant
Adds the Rust standalone runtime baseline across CLI, HTTP, MCP, LSP, workbench, Python bridge, DuckDB extension wiring, WASM, C ABI, and CI gates.
This PR now also closes the follow-up items that were safe to address before merge:
ORDER BYreferences.?format=arroworAccept: application/vnd.apache.arrow.stream.Important scope notes:
Local gates are green: Rust cargo format/check/test/clippy coverage for the changed standalone surfaces, SQLite ADBC probe, Python ruff check/format, and the full Python pytest suite.