Repository navigation
Add @Suite to top-level *Tests types missing the annotation - #2
Closed
sidepelican with Copilot wants to merge 1 commit into
Closed
sidepelican with Copilot wants to merge 1 commit into
sidepelican with Copilot wants to merge 1 commit into
Conversation
Agent-Logs-Url: https://github.com/sidepelican/swift-java/sessions/ba01485e-36ad-4376-b9be-729bcc2de0fc Co-authored-by: sidepelican <19257572+sidepelican@users.noreply.github.com> # Conflicts: # Tests/JExtractSwiftTests/JNI/JNIIntConversionChecksTests.swift
sidepelican
force-pushed
the
copilot/add-suite-annotation-to-tests
branch
from
April 20, 2026 00:55
87fee4d to
b06fbfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several top-level test types named
*Testsusingimport Testingwere inconsistently missing@Suite, with no apparent reason for the omission.Changes
@Suiteto 17 files inTests/JExtractSwiftTests/(includingJNI/subdirectory) that use Swift Testing but lacked the annotation:ByteArrayTests,ClassPrintingTests,DataImportTests,ExtensionImportTests,FFMNestedTypesTests,FuncCallbackImportTests,InternalExtractTests,MethodImportTests,MethodThunkTests,OptionalImportTests,SendableTests,StringPassingTests,SwiftDocumentationParsingTests,UnsignedNumberTests,VariableImportTests,JNIIntConversionChecksTests,JNIUnsignedNumberTestsSwiftJavaToolLibTests,SwiftJavaTests,SwiftJavaMacrosTests) were intentionally left unchanged