fix(pstack): drop control-ui and cloud spawn leftovers - #16
Open
shishiv wants to merge 1 commit into
Open
Conversation
Opening a PR names the project verify scripts. Orchestrate spawn fields match runs.run. The denylist fails CI if those Cursor phrases return. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Playbooks that survived the leftover denylist still named Cursor cloud and
control-ui. Operators need the projectverify-*scripts and Piworktreefields.Scope
skills/poteto-mode/playbooks/opening-a-pr.mdnamesnpm run verify:deterministic,npm run verify:browser, Playwright, or targeted tests. The cloud-agent draft sentence is gone.draft: falsestays.skills/poteto-mode/playbooks/orchestrate.mdnested spawns useagent,task, andworktree, plus optionalmodel,role, andreadOnly. Drain wakes usesubagent_waitor a Pi schedule. After a Pi restart, local agents are dead. Reattach by PR and branch.test/resources/resources.test.mjsbanscontrol-ui,control-cli,cloud spawns,cloud work is not, andthe loop skill. It does not ban the English word environment.rg "control-ui|control-cli|cloud spawns" skills/poteto-mode/playbooksis empty.Out of scope: deleting unused
src/workflowsmodules.Tradeoffs
The denylist does not ban
environment. That word is still valid in Sentry tags, eval setup, and "this environment".Blast Radius
Coordinators following Opening a PR or Orchestrate verify with this package's scripts. Spawn fields match
buildSingleChildWorkflowScript.Verification
The denylist was added first and failed on
control-ui remains in active resources.node --test test/resources/resources.test.mjspassed (4 tests).npm run verify:deterministicpassed (format, lint, typecheck, 79 tests, manifest).Made with Cursor