test(pstack): ban leftover spawn strings in the resource grep - #13
Open
shishiv wants to merge 1 commit into
Open
test(pstack): ban leftover spawn strings in the resource grep#13shishiv wants to merge 1 commit into
shishiv wants to merge 1 commit into
Conversation
The corpus denylist now fails CI on a doubled subagent token and on spawning Comment Sicko by display name. how and no-comments already match the Pi agent id. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The resource corpus test is the leftover detector. This PR adds two tokens the skills can already make green, so
mainstays green while later phases grow the same list.Scope
test/resources/resources.test.mjsnow bansagent: "Comment Sicko"andsubagent subagent. It also requiresagent: "comment-sicko"inskills/no-comments/SKILL.md.skills/how/SKILL.mddrops the doubledsubagent subagentat the two spawn sites.skills/no-comments/SKILL.mdspawnscomment-sickoby agent id. The display name Comment Sicko stays in the description and prose.agents/comment-sicko.mdis unchanged.Out of scope:
create-skill,control-ui,control-cli, and the$PI_SESSION_FILEleftover sentence. Those land in later phases on the same denylist.Tradeoffs
The denylist grows by only the tokens this PR can green. Adding the rest now would fail
main.Blast Radius
Anyone who follows
howor/skill:no-commentsnow sees Pi spawn ids. The heading# Comment Sickostill matches the character name. CI fails if those leftover strings return.Verification
node --test test/resources/resources.test.mjspassed (4 tests). The denylist was added first and failed onComment Sicko spawnbefore the skill edits.npm run verify:deterministicpassed (format, lint, typecheck, 79 tests, manifest).Comment Sicko reported deletion count 0.
Made with Cursor