Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions .claude-plugin/marketplace.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"name": "dev-workflows",
"source": "./dev-workflows",
"strict": true,
"version": "0.30.0",
"version": "0.31.0",
"description": "Skills + Subagents for backend development - Use skills for coding guidance, or run recipe workflows for full orchestrated agentic coding with specialized agents",
"author": {
"name": "Shinsuke Kagawa",
Expand Down Expand Up @@ -80,7 +80,7 @@
"name": "dev-workflows-frontend",
"source": "./dev-workflows-frontend",
"strict": true,
"version": "0.30.0",
"version": "0.31.0",
"description": "Skills + Subagents for React/TypeScript - Use skills for coding guidance, or run recipe workflows for full orchestrated agentic coding with specialized agents",
"author": {
"name": "Shinsuke Kagawa",
Expand Down Expand Up @@ -140,15 +140,14 @@
"./skills/recipe-update-doc",
"./skills/requirement-convergence",
"./skills/subagents-orchestration-guide",
"./skills/testing-principles",
"./skills/typescript-rules"
"./skills/testing-principles"
]
},
{
"name": "dev-workflows-fullstack",
"source": "./dev-workflows-fullstack",
"strict": true,
"version": "0.30.0",
"version": "0.31.0",
"description": "Skills + Subagents for fullstack development (backend + React/TypeScript) - Use skills for coding guidance, or run recipe workflows for full orchestrated agentic coding with specialized agents",
"author": {
"name": "Shinsuke Kagawa",
Expand Down Expand Up @@ -225,15 +224,14 @@
"./skills/recipe-update-doc",
"./skills/requirement-convergence",
"./skills/subagents-orchestration-guide",
"./skills/testing-principles",
"./skills/typescript-rules"
"./skills/testing-principles"
]
},
{
"name": "dev-skills",
"source": "./dev-skills",
"strict": true,
"version": "0.30.0",
"version": "0.31.0",
"description": "Lightweight skills for users with existing workflows - coding best practices, testing principles, and design guidelines without recipe workflows or agents",
"author": {
"name": "Shinsuke Kagawa",
Expand All @@ -260,8 +258,7 @@
"./skills/integration-e2e-testing",
"./skills/llm-friendly-context",
"./skills/requirement-convergence",
"./skills/testing-principles",
"./skills/typescript-rules"
"./skills/testing-principles"
]
}
]
Expand Down
2 changes: 2 additions & 0 deletions agents/acceptance-test-generator.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ Each selected test records:
- proof obligation: boundary to traverse, expected state/results, pass criteria, real dependencies and permissible substitutes;
- a distinct branch, state, lifecycle or fallback path when the main path could remain green through a material regression.

File-level comments hold only what the completed tests keep, such as the lane declaration and setup the tests share; each test's record carries the rest.

Keep executable assertions and mock implementation for the implementing task. Test Boundaries marking a dependency as real are carried as `@real-dependency: [component]`.

## Output
Expand Down
5 changes: 3 additions & 2 deletions agents/code-reviewer.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Verify by reading the changed code and tests. Running tests and quality checks i
## Inputs

- **governingDocuments**: One or more approved Design Docs, or the resolved Work Plan when the caller has no Design Doc, as a list of document paths
- **implementationFiles**: The complete set of implementation, test, schema, build, deployment, and runtime-configuration artifacts in the reviewed change
- **implementationFiles**: The implementation, test, schema, build, deployment, and runtime-configuration artifacts whose changes this review judges: the complete change, or one review unit of it
- **Work Plan and task scope**: Use when supplied to identify approved execution and review boundaries
- **prior_feedback** (optional): Array of `{ id, disposition, reason?, evidence }` from the preceding Review Resolution decision

Expand All @@ -31,6 +31,7 @@ Before reviewing, read these files; they hold review criteria beyond the preload

- `references/frontend.md` in the testing-principles skill
- `references/frontend.md` in the ai-development-guide skill
- `references/frontend.md` in the coding-principles skill
- `references/e2e.md` in the testing-principles skill

## Initial Review
Expand All @@ -40,7 +41,7 @@ Extract the approved outcome, applicable acceptance criteria, changed interfaces
Judge the material surfaces in `implementationFiles` against these criteria:

- **Outcome and contracts**: The changed code and tests deliver each applicable criterion at file:line and preserve public, serialized, persisted, user-visible, error, identifier, and producer-consumer contracts.
- **Scope economy**: For each material mechanism, abstraction, dependency, state, defensive control, or test added by the change, identify the required result it serves (an approved requirement, repository rule, observed contract or failure, or evidence-backed material risk in the reachable changed path) and whether omitting it, narrowing it, or reusing existing code or tests would serve that result; an addition is worth its lifecycle cost only when none of these would. A Design Doc that selected the mechanism records the current means, not that justification. For a test, judge this by the testing-principles Test Selection rules.
- **Scope economy**: For each material mechanism, abstraction, dependency, state, defensive control, or test added by the change, identify the required result it serves (an approved requirement, repository rule, observed contract or failure, or evidence-backed material risk in the reachable changed path) and whether omitting it, narrowing it, or reusing code or tests that already hold the same responsibility, in the repository or elsewhere in this change (coding-principles Reference Representativeness), would serve that result; an addition is worth its lifecycle cost only when none of these would. A Design Doc that selected the mechanism records the current means, not that justification. For a test, judge this by the testing-principles Test Selection rules.
- **Required design and proof**: Preserve the governing source's responsibility boundaries. Require proof at the observable boundary claimed by the governing source or task. Each changed test is itself a surface: judge the claim it proves and the boundary it proves it at, because tests looked up only as evidence for criteria never reveal a claim proven twice.
- **Code quality**: Apply the preloaded skills to concrete changed-path correctness, contract safety, repository-local patterns, error behavior, and proof quality.
- **Repository quality policy**: Apply each `docs/project-context/quality.yaml` dimension whose `applies_when` condition matches the change. Its `pass` condition and cited `evidence` define the accepted state.
Expand Down
2 changes: 1 addition & 1 deletion agents/code-verifier.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ For reverse-engineered/as-is documents, verify every supplied inventory item at

Use one authoritative definition when it directly proves an identifier or contract. Seek another source when behavior, indirection, or conflicting evidence makes it decision-relevant. Base confidence on evidence quality rather than source count.

Stop expanding the search when additional evidence cannot change a discrepancy or limitation.
Stop expanding the search when the evidence that could change a discrepancy or limitation has been checked; find existing code as coding-principles Reference Representativeness describes.

## Rerun Boundary

Expand Down
2 changes: 1 addition & 1 deletion agents/codebase-analyzer.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Return a fact only when it can:
- identify a lifecycle-cost or maintainability difference; or
- select a verification boundary.

Stop expanding the search when another fact cannot change one of those outcomes. Inspect all known consumers only for a public, shared, serialized, persistent, security, or error contract whose complete consumer set controls compatibility. Otherwise, representative callers, tests, configuration, and siblings are sufficient.
Existing code with the same responsibility as a new surface may share no name or reference with it; look for reuse through position and role (sibling features, files with the same role in the same layer, shared layers) and through shared input and purpose, as well as through references. Stop expanding the search when the facts that could change one of those outcomes have been checked; a search with no match shows only that the search found nothing. Inspect all known consumers only for a public, shared, serialized, persistent, security, or error contract whose complete consumer set controls compatibility. Otherwise, representative callers, tests, configuration, and siblings are sufficient.

## Execution Steps

Expand Down
20 changes: 10 additions & 10 deletions agents/quality-fixer-frontend.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: quality-fixer-frontend
description: Specialized agent for verifying React projects and fixing frontend quality failures within the current task scope. Use proactively after code changes or for quality, test, build, lint, format, type, or fix requests.
tools: Bash, Read, Edit, MultiEdit, Grep, Glob, LS
skills:
- typescript-rules
- coding-principles
- testing-principles
- ai-development-guide
- external-resource-context
Expand Down Expand Up @@ -77,7 +77,7 @@ Run every applicable check discovered in Step 2. Use repository-declared command
- Reuse mutation evidence after confirming complete fields, matching revision/files, restoration, and proof of the claimed behavior; otherwise replace it with fresh evidence.

### Step 4: Fix Errors
Apply fixes per typescript-rules, testing-principles, and ai-development-guide skills, reading `references/frontend.md` in the ai-development-guide skill for frontend criteria and check troubleshooting. For a failing component, hook, or UI integration test, read `references/frontend.md` in the testing-principles skill, and for a failing browser E2E test `references/e2e.md`; they define whether the test or the implementation is wrong.
Apply fixes per coding-principles, testing-principles, and ai-development-guide skills, reading `references/frontend.md` in the coding-principles skill for frontend coding rules and in the ai-development-guide skill for frontend criteria and check troubleshooting. For a failing component, hook, or UI integration test, read `references/frontend.md` in the testing-principles skill, and for a failing browser E2E test `references/e2e.md`; they define whether the test or the implementation is wrong.

### Step 5: Repeat Until Checks Pass
- In-scope error found → Fix → Re-run checks
Expand All @@ -96,15 +96,15 @@ Return one of the following as the final response (see Output Format for schemas
## Frontend-Specific Quality Criteria

### Repository-Local Choice Discipline
Prefer repository-local component patterns over generic React advice; when patterns coexist for the same concern, follow the dominant one in the changed feature area — the surrounding feature folder, or the nearest parent directory containing siblings using the same concern. When no repository choice covers the concern, select the lowest-surface sufficient option using the governing value boundary and available technical evidence; novelty alone is not a reason for `blocked`.
Prefer repository-local component patterns over generic React advice; when patterns coexist for the same concern, choose as coding-principles Reference Representativeness describes. When no repository choice covers the concern, select the lowest-surface sufficient option using the governing value boundary and available technical evidence; novelty alone is not a reason for `blocked`.

### Testing Quality
- **Mock layering**: Browser-primitive doubles (e.g., ResizeObserver, IntersectionObserver, time, router/provider) are acceptable when the test environment requires them; the component under test is exercised through real renders and user interactions
- **Query selection**: Prefer role/name queries for user-visible elements; use async queries (`findBy*`, `waitFor`) for async appearance and `queryBy*`/`queryAllBy*` only when asserting intentional absence

### Build Quality
- **Zero Type Errors**: TypeScript build must succeed without errors; Props and State have explicit type definitions. Permit `any` only at an evidence-backed, narrowly bounded exception that satisfies typescript-rules
- **Bundle / code-splitting fixes**: Apply the evidence and verification rule in typescript-rules
- **Zero Type Errors**: TypeScript build must succeed without errors; Props and State have explicit type definitions. Permit `any` only at an evidence-backed, narrowly bounded exception that satisfies the coding-principles frontend reference
- **Bundle / code-splitting fixes**: Apply the evidence and verification rule in the coding-principles frontend reference

## Status Determination Criteria

Expand Down Expand Up @@ -228,7 +228,7 @@ Between tool calls, briefly report: which phase is running, the command executed
- **Clear Type Error Fixes**
- Add import statements (when types not found)
- Add type annotations for Props/State (when inference impossible)
- Replace `any` with `unknown` plus validation for untyped external API responses; preserve only the documented, bounded exceptions allowed by typescript-rules
- Replace `any` with `unknown` plus validation for untyped external API responses; preserve only the documented, bounded exceptions allowed by the coding-principles frontend reference
- Add optional chaining
- **Clear Code Quality Issues**
- Remove unused variables/functions/components
Expand All @@ -243,15 +243,15 @@ Between tool calls, briefly report: which phase is running, the command executed
- Integration test failure: Investigate and fix component integration
- Boundary value test failure: Confirm specification and fix
- **Bundle / Rendering Optimization**
- Apply only when Step 3 reports bundle evidence that satisfies typescript-rules or profiler evidence identifies the changed render path
- Apply only when Step 3 reports bundle evidence that satisfies the coding-principles frontend reference or profiler evidence identifies the changed render path
- Use the repository's existing loading/import pattern and the smallest fix that addresses that evidence; re-run the same bundle or profiler signal
- Add manual memoization only for the profiler- or identity-based conditions in typescript-rules
- Add manual memoization only for the profiler- or identity-based conditions in the coding-principles frontend reference
- **Structural Issues**
- Resolve circular dependencies (extract to common modules)
- Split components when independent rendering, state, data, or test responsibilities create material coupling or verification cost; retain a cohesive component when splitting would add avoidable prop/state synchronization
- Refactor deeply nested conditionals
- **Type Error Fixes**
- Resolve external API response types by the typescript-rules boundary validation policy
- Resolve external API response types by the coding-principles frontend reference's boundary validation policy
- Add necessary Props type definitions
- Flexibly handle with generics or union types

Expand Down Expand Up @@ -286,7 +286,7 @@ All fixes must satisfy these criteria:
|----------|------------|
| Test integrity | Tests remain executable and active (no `it.skip`, no deletion for convenience) |
| Assertion quality | Every test contains meaningful assertions that verify behavior (not `expect(true).toBe(true)`) |
| Type safety | Prefer explicit types (`unknown`, generics, unions); permit only documented, bounded `any` exceptions from typescript-rules and justified project-configured suppressions |
| Type safety | Prefer explicit types (`unknown`, generics, unions); permit only documented, bounded `any` exceptions from the coding-principles frontend reference and justified project-configured suppressions |
| Error handling | Handle errors with context (log, propagate, or recover with specific handling) |
| Environment separation | Keep test-specific branches (e.g. `import.meta.env.MODE` checks) outside production code |
| ESLint compliance | Preserve ESLint rules (add justification comments when override is necessary) |
Expand Down
Loading
Loading