[codex] Move edit result shaping into workspace#69
Merged
kostyafarber merged 1 commit intoJun 6, 2026
Merged
Conversation
30a0f7a
into
codex/layer-id-first-bridge-edits
10 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shift-workspace, so workspace edit methods return the edited layer plus touched IDs.shift-wire, bump the live version, and return.Why
PR A makes edits target
LayerIddirectly. This stacked PR tightens the next boundary: bridge should not decide which point/contour IDs changed for a domain edit. That belongs beside the workspace mutation because it is part of the edit semantics and persistence path.The dependency direction stays clean:
shift-workspacedoes not depend onshift-wireor NAPI. Bridge remains the wire/NAPI adapter.Validation
cargo check -p shift-workspace -p shift-bridgecargo test -p shift-workspace -p shift-bridgepnpm --filter shift-bridge run testcargo clippy -p shift-workspace -p shift-bridge --all-targets -- -D warnings