Skip to content

[codex] Move edit result shaping into workspace#69

Merged
kostyafarber merged 1 commit into
codex/layer-id-first-bridge-editsfrom
codex/thin-bridge-workspace-edits
Jun 6, 2026
Merged

[codex] Move edit result shaping into workspace#69
kostyafarber merged 1 commit into
codex/layer-id-first-bridge-editsfrom
codex/thin-bridge-workspace-edits

Conversation

@kostyafarber
Copy link
Copy Markdown
Collaborator

Summary

  • Adds workspace-domain edit result structs for glyph value and structure edits.
  • Moves changed-entity ownership into shift-workspace, so workspace edit methods return the edited layer plus touched IDs.
  • Simplifies bridge mutation methods so they parse NAPI inputs, call workspace, convert the workspace edit result to shift-wire, bump the live version, and return.

Why

PR A makes edits target LayerId directly. This stacked PR tightens the next boundary: bridge should not decide which point/contour IDs changed for a domain edit. That belongs beside the workspace mutation because it is part of the edit semantics and persistence path.

The dependency direction stays clean: shift-workspace does not depend on shift-wire or NAPI. Bridge remains the wire/NAPI adapter.

Validation

  • cargo check -p shift-workspace -p shift-bridge
  • cargo test -p shift-workspace -p shift-bridge
  • pnpm --filter shift-bridge run test
  • cargo clippy -p shift-workspace -p shift-bridge --all-targets -- -D warnings
  • commit hooks: cargo check/fmt/clippy/test

@kostyafarber kostyafarber marked this pull request as ready for review June 6, 2026 15:36
@kostyafarber kostyafarber merged commit 30a0f7a into codex/layer-id-first-bridge-edits Jun 6, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant