[codex] Remove font layer registry#64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the obsolete font-level
Layerregistry fromshift-fontnow that authored glyph data is modeled asSource+GlyphLayer.This PR:
FontData.layers,default_layer_id, and the associatedFontAPIsshift_font::Layermodule/exportFontViewand bridge export snapshots so they no longer expose font-level layerssourceIdforGlyphLayerRefWhy
The old font-level layer registry duplicated information now carried by sources and glyph layers. Keeping it around made the next workspace semantic API work harder because edits could accidentally target old layer concepts instead of stable source/glyph-layer identity.
Validation
Local commit hooks passed:
cargo checkincluding testscargo fmtcargo clippycargo testvitestAdditional manual validation run before commit:
cargo check --workspacecargo test --workspacepnpm --filter @shift/desktop typecheckpnpm test