Skip to content

[codex] Remove font layer registry#64

Merged
kostyafarber merged 1 commit into
mainfrom
codex/remove-font-layer-registry
Jun 6, 2026
Merged

[codex] Remove font layer registry#64
kostyafarber merged 1 commit into
mainfrom
codex/remove-font-layer-registry

Conversation

@kostyafarber
Copy link
Copy Markdown
Collaborator

Summary

Removes the obsolete font-level Layer registry from shift-font now that authored glyph data is modeled as Source + GlyphLayer.

This PR:

  • removes FontData.layers, default_layer_id, and the associated Font APIs
  • deletes the old shift_font::Layer module/export
  • updates backend readers and tests to treat imported UFO/designspace/Glyphs layers as sources
  • simplifies FontView and bridge export snapshots so they no longer expose font-level layers
  • updates bridge JS tests to use sourceId for GlyphLayerRef

Why

The old font-level layer registry duplicated information now carried by sources and glyph layers. Keeping it around made the next workspace semantic API work harder because edits could accidentally target old layer concepts instead of stable source/glyph-layer identity.

Validation

Local commit hooks passed:

  • cargo check including tests
  • cargo fmt
  • cargo clippy
  • cargo test
  • vitest

Additional manual validation run before commit:

  • cargo check --workspace
  • cargo test --workspace
  • pnpm --filter @shift/desktop typecheck
  • pnpm test

@kostyafarber kostyafarber marked this pull request as ready for review June 6, 2026 06:10
@kostyafarber kostyafarber merged commit a4b9265 into main Jun 6, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant