Skip to content

fix(hooks): register the bash hook functions only once #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnnatarHe merged 1 commit into from
Nov 10, 2026
+22 −3
Merged

fix(hooks): register the bash hook functions only once #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions hooks/bash.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,25 @@ precmd_invoke_cmd() {
shelltime track -s=bash -id=$SESSION_ID -cmd="$CMD" -p=post -r=$LAST_RESULT --ppid=$PPID &> /dev/null
}

# Set the functions for bash-preexec
preexec_functions+=(preexec_invoke_cmd)
precmd_functions+=(precmd_invoke_cmd)
# Succeeds when the function name in $1 is one of the other arguments.
_shelltime_has_hook() {
local fn="$1" hook
shift
for hook in "$@"; do
if [ "$hook" == "$fn" ]; then
return 0
fi
done
return 1
}

# Set the functions for bash-preexec, once. Sourcing this file again (as
# `source ~/.bashrc` does) would otherwise register them twice and every
# command would be tracked twice.
if ! _shelltime_has_hook preexec_invoke_cmd "${preexec_functions[@]:-}"; then
preexec_functions+=(preexec_invoke_cmd)
fi
if ! _shelltime_has_hook precmd_invoke_cmd "${precmd_functions[@]:-}"; then
precmd_functions+=(precmd_invoke_cmd)
fi
unset -f _shelltime_has_hook
Loading