fix(jsx-email): relax react catalog pins to ^19.2.0#455
Merged
Conversation
Owner
|
@CharlieHelps that is not the fix discussed in the associated issue |
Contributor
Author
|
@shellscape You’re right — I implemented the initial issue-body proposal and missed the clarified fix in #454 (comment). I have not pushed additional changes yet. If you want me to proceed, I’ll update this PR to:
If you want that pattern applied outside |
Owner
|
@CharlieHelps implement that fix |
Contributor
Author
|
Implemented check complete — this fix is already in the PR branch, so no additional commit was needed. Verified on
|
Owner
|
@CharlieHelps implement the proper fix you identified in #455 (comment) |
Contributor
Author
|
Implemented — I applied the fix from my earlier note and pushed it to this PR: Changes
Validation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm-workspace.yaml:react:19.2.5->^19.2.0react-dom:19.2.5->^19.2.0Rationale
This avoids duplicate React installs when consumers are on newer React 19 patch versions.
Closes #454
Validation notes
maindue to pre-existing issues.