You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@CharlieHelps npm recently revoked all classic tokens which allowed us to publish to npm from github actions. refactor the release.yml workflow to support id-token: write, remove NPM_TOKEN and NODE_AUTH_TOKEN use from the workflow and the repository.
Maintained the OIDC-focused changes in .github/workflows/release.yml, .moon/tasks.yml, .npmrc, and scripts/release-publish.sh, keeping all NPM_TOKEN / NODE_AUTH_TOKEN usage removed in line with #395.
Updated the Moon release task in .moon/tasks.yml so the command now chains versioner --target "$projectRoot" --publish=false && ../../scripts/release-publish.sh "$projectRoot", ensuring release-publish.sh only runs if versioner succeeds and making failure ordering explicit.
Extended scripts/release-publish.sh to verify pnpm is available via command -v pnpm with a clear error message before proceeding, then log both Packing to $PACK_DIR and Running pnpm pack in $project_root prior to pnpm pack --pack-destination "$PACK_DIR" for better CI debuggability.
Re-ran pnpm exec prettier --check .moon/tasks.yml to confirm the updated release task YAML stays formatted correctly and executed bash -n scripts/release-publish.sh to validate the modified shell script parses cleanly.
Clarified in review comments that .github/workflows/release.yml pins npm@11.5.1 specifically to guarantee npm publish --provenance support on GitHub runners, and that contents: write remains scoped to the release job for versioner commits/tags.
Refined scripts/release-publish.sh to drop npx and instead use a pinned npm CLI via pnpm dlx "$NPM_CLI_SPEC" publish --provenance, then validated formatting and shell parsing with pnpm exec prettier --check .github/workflows/release.yml .moon/tasks.yml and bash -n scripts/release.sh scripts/release-publish.sh.
Added a POSIX-shell note to the release task in .moon/tasks.yml, clarified local auth expectations in .npmrc with a ~/.npmrc comment, expanded scripts/release.sh to require both pnpm and node in a loop, and re-validated with pnpm exec prettier --check .moon/tasks.yml plus bash -n scripts/release.sh (both passing).
Inserted a clarifying comment above the Release step in .github/workflows/release.yml explaining that npm auth is handled via GitHub OIDC in scripts/release*.sh (no NPM_TOKEN needed), and confirmed formatting via pnpm exec prettier --check .github/workflows/release.yml.
Addressed self-review feedback by documenting the OIDC permission policy in .github/workflows/release.yml (jobs needing npm OIDC must request id-token: write), expanding the always-auth explanation in .npmrc so contributors know they need valid ~/.npmrc credentials for private/publish flows, and logging the resolved NPM_CLI_SPEC in scripts/release-publish.sh before the pnpm dlx publish call for better CI observability.
Opened PR #396 (fix(repo): publish releases to npm via OIDC) containing the release.yml / .npmrc / .moon/tasks.yml / scripts/release*.sh changes, requested review from shellscape and CharlieHelps, and documented the verification steps (pnpm exec prettier --check ... and bash -n scripts/release.sh scripts/release-publish.sh) in the PR body.
Opened PR #396 to switch the release pipeline over to npm OIDC publishing (no classic tokens), per #395.
Changes
Updated .github/workflows/release.yml to request id-token: write at the job level (OIDC) and removed NPM_TOKEN/NODE_AUTH_TOKEN usage.
Removed the repo-level npm token config from .npmrc (and added clarifying comments about auth expectations).
Updated the Moon release task to run scripts/release.sh, which:
runs versioner --publish=false
packs with pnpm pack (so workspace: deps are rewritten)
publishes via pnpm dlx npm@11.5.1 publish --provenance using OIDC
refuses to publish outside GitHub Actions unless ALLOW_LOCAL_PUBLISH=1 is set
Note: for the publish to succeed, npm “Trusted Publisher” / OIDC needs to be configured on the npm side for these packages to allow publishes from this repo/workflow.
Verification
# Install: OK
$ pnpm install --frozen-lockfile
# Prettier: All matched files use Prettier code style!
$ pnpm exec prettier --check .github/workflows/release.yml .moon/tasks.yml
# Shell syntax: OK
$ bash -n scripts/release.sh scripts/release-publish.sh
Inspected the workflow logs for the failed Release Projects run linked from issue #395 to understand at which step the publish attempt stopped and what error surfaced.
Searched the repo for versioner usage and confirmed the Moon task wiring in .moon/tasks.yml, where the release task runs versioner --target $projectRoot after ~:build.
Reviewed the release task configuration in .moon/tasks.yml to see that it disables caching and runs dependencies serially, which helps narrow down whether the failure is in build vs. the versioner invocation itself.
Fetched metadata for the workflow run head commit f6391f3e3a8de5429d22101e47e184d7263dec01 via gh api, confirming it corresponds to "chore(jsx-email): upgrade react-router-dom to 7.12.0 (chore: upgrade react-router-dom to 7.12.0 #394)" and identifying its parent 1232d5ff5ff67e90e14cf02f1ec46183c10c4739 for context on what @dot/versioner was diffing against.
Cloned shellscape/dot locally and verified the layout of packages/versioner to work against the current @dot/versioner implementation.
Searched packages/versioner/src for publish usage and located the publish helper plus its invocation within versioner.ts.
Reviewed the argv parsing in packages/versioner/src/versioner.ts to see that publish and push behavior are controlled via yargs-parser flags (dry, publish, push, tag).
Examined the publish function in packages/versioner/src/versioner.ts and confirmed it calls pnpm publish --no-git-checks unless --dry is passed or --publish=false is explicitly set on the CLI, in which case it logs {yellow Skipping Publish} instead.
Probed the GitHub REST contents API for .github/workflows at commit f6391f3e3a8de5429d22101e47e184d7263dec01 and then listed the local .github/workflows directory to confirm that release.yml is the workflow referenced by the failing Release Projects run.
Fetched and decoded .github/workflows/release.yml at commit f6391f3e3a8de5429d22101e47e184d7263dec01, confirming the Release Projects job checks out ref: main, runs moon jsx-email:build plus other builds, performs an OIDC Preflight check, and then triggers moon run :release --affected --concurrency 1 --remote, which is the entry point that ultimately calls @dot/versioner.
Pulled the failed logs from the Release Projects run (job 60045408544). The failure is coming from versioner trying to publish via pnpm publish, which (unlike the npm CLI) can’t use GitHub’s OIDC “Trusted Publisher” flow—so with classic tokens removed, it just hard-fails with missing auth.
In the job log, jsx-email:release reaches:
Publishing to NPM
runs pnpm publish --no-git-checks
then errors with npm error code ENEEDAUTH / “need auth … npm adduser”, and versioner exits non-zero.
This matches versioner’s implementation in shellscape/dot:
packages/versioner/src/versioner.ts has publish() calling execa('pnpm', ['publish', '--no-git-checks'], ...) unless --publish=false is passed. (See around here: packages/versioner/src/versioner.ts lines ~148–160 in that repo.)
So, even though the workflow is already requesting id-token: write (OIDC), the actual publish path being executed (pnpm publish) never uses it.
What needs to change (in this repo):
Ensure releases run versioner with publishing disabled (--publish=false), and then publish with the npm CLI (e.g. npm publish --provenance) in a separate step/script.
Concretely, the current Moon task is versioner --target $projectRoot (no --publish=false), which is why we’re hitting pnpm publish.
Smaller sidenote: Moon is also warning about a shallow checkout when doing --affected, but that’s not the cause of this publish failure.
@CharlieHelps please consult the pnpm documentation to double check if it doesnt support oidc. I'm pretty sure it does, so there's another reason why pnpm publish isnt working with oidc
Checked pnpm’s official documentation and authentication guides to look for any references to OIDC, including how pnpm publish authenticates in CI environments.
Compared pnpm’s publish/auth behavior against npm’s documented OIDC support to understand any gaps affecting pnpm publish with GitHub Actions OIDC workflows in jsx-email.
Double-checked pnpm’s docs + upstream threads: pnpm publishdoes document --provenance, but it doesn’t document npm “Trusted Publisher” / GitHub OIDC auth support (it still reads like it expects normal registry auth via .npmrc).
On the npm side, OIDC “Trusted Publisher” publishing is currently described as an npm CLI feature (and npm calls out the need for a sufficiently new npm CLI).
Also notable: pnpm upstream has an (as of now) draft PR explicitly trying to add OIDC publishing support by letting pnpm download/use a particular npm CLI for publishing (which strongly suggests this isn’t generally supported in released pnpm yet).
Interpreted the comment on #395 as frustration about response speed rather than a new requirement or change in scope for the jsx-email work.
Attempted to check the status of PR #396 and related publishing workflow details via gh pr view 396, saw the command fail due to requesting an unsupported merged JSON field, and confirmed this doesn’t change the underlying work on the npm publishing strategy.
Queried the main pnpm settings documentation at https://pnpm.io/settings with a search for npmVersion/npmPath, confirmed npmPath is documented as a configurable setting, and noted there is no first-class npmVersion setting exposed there for pinning.
Searched the pnpm-workspace.yaml docs at https://pnpm.io/pnpm-workspace_yaml for npmVersion/npmPath and confirmed there is no workspace-level configuration for these, reinforcing that any npm pinning will likely live in scripts or CI tooling rather than workspace config.
Looked at pnpm/pnpm#9812 — it’s explicitly a feature request to support npm “trusted publishing” (OIDC), and it points at pnpm/pnpm#10092 as the upstream work to make pnpm publish use a specific npm CLI for publishing.
That lines up with the failure we saw: versioner was invoking pnpm publish ... and hitting ENEEDAUTH because the OIDC support lives in the npm CLI (and npm notes it requires npm>= 11.5.1). In other words: pnpm publish won’t “just work” with OIDC unless it’s actually running an OIDC-capable npm under the hood (and is configured to do so).
That’s also why the fix in PR #396 went with versioner --publish=false + pnpm dlx npm@11.5.1 publish --provenance in scripts/release-publish.sh: it guarantees the correct npm CLI is what performs the publish step.
@CharlieHelps I see. You have been added to the shellscape/dot repository. Please open a PR on that repository for changing the publish command to use npm instead of pnpm within the versioner package. Also update the repo to use OIDC following the changes you made to this (jsx-email) repository as well.
Cloned the shellscape/dot repo into the workspace and inspected .github/workflows/release.yml to understand the existing pnpm-based publish flow and NPM_TOKEN usage.
Reviewed the Release and Publish Changed Packages step plus root package.json and packages/**/package.json to see how @dot/versioner is invoked and how workspace packages are published.
Located the publish helper in packages/versioner/src/versioner.ts and confirmed it previously called execa('pnpm', ['publish', '--no-git-checks'], { cwd, stdio: 'inherit' }); as the core publish path.
Checked jsx-email's release workflow and .github/actions/setup/action.yml to mirror the Node 20 + actions/setup-node + id-token: write OIDC pattern for npm Trusted Publisher.
Created a dedicated fix/versioner/npm-oidc-publish branch in shellscape/dot to isolate changes for switching @dot/versioner to npm publish with OIDC.
Updated packages/versioner/src/versioner.ts so publish now pnpm packs to a temp dir, detects OIDC via ACTIONS_ID_TOKEN_REQUEST_*, and then runs pnpm dlx npm@11.5.1 publish --no-git-checks [--provenance] <tarball>, with an NPM_CLI_SPEC constant and temp-dir cleanup via rmSync in a finally block, plus import tweaks (mkdtempSync, readdirSync, rmSync, tmpdir) to satisfy ESLint.
Updated the root .npmrc to drop NPM_TOKEN-based auth and document that CI publishing uses npm Trusted Publisher via GitHub OIDC while local publishes rely on the developer’s ~/.npmrc.
Refreshed .github/workflows/release.yml to use actions/checkout@v4, actions/setup-node@v4 with Node 20, declare permissions (including id-token: write), add an OIDC Preflight step, shift pnpm/action-setup@v4 earlier, and remove NODE_AUTH_TOKEN/NPM_TOKEN from the Release and Publish Changed Packages step, then ran pnpm lint to confirm formatting/linting pass aside from an existing packages/cdk/src/methods/security.ts warning.
Installed workspace deps via pnpm install --frozen-lockfile, ran pnpm -r build and AWS_REGION='us-east-1' pnpm --filter "...[origin/master]" test to validate the updated flow, and spot-checked packages/*/package.json to confirm @dot/access, @dot/config, and @dot/log all still run FORCE_COLOR=2 ava.
Committed the changes as fix(repo,versioner): publish with npm via OIDC, pushed fix/versioner/npm-oidc-publish to GitHub, and reviewed .github/PULL_REQUEST_TEMPLATE.md plus recent merged PRs to align the upcoming PR title/body with the repo’s conventions.
Opened a PR on shellscape/dot to switch @dot/versioner publishing over to the npm CLI (OIDC/Trusted Publisher compatible) and update the repo release workflow accordingly: shellscape/dot#6
Changes (dot)
@dot/versioner: replaced pnpm publish with pnpm pack + pnpm dlx npm@11.5.1 publish (adds --provenance automatically when the GitHub OIDC env vars are present).
Repo: removed token-based npm auth (.npmrc) and updated .github/workflows/release.yml to request id-token: write (and removed NPM_TOKEN / NODE_AUTH_TOKEN).
Checked git status --porcelain=v1 on chore/repo/update-versioner and found a large set of untracked TypeScript emit artifacts under packages/jsx-email/src/** created by jsx-email:tsc.
Inspected packages/jsx-email/tsconfig.json and confirmed it extends ../../shared/tsconfig.base.json and includes src/**/*.ts / src/**/*.d.ts, which explains why tsc emits into src when run directly.
Cleaned the untracked build artifacts with git clean -fd packages/jsx-email/src, removing the compiled .js, .d.ts, and .map files so they don’t pollute the new PR diff.
Re-ran git status --porcelain=v1 and verified the working tree is now clean, with only the intended @dot/versioner and snapshot updates tracked on chore/repo/update-versioner.
Reviewed the last several merged PRs via gh pr list --state merged --limit 10 to confirm conventions for titles like chore: ... / fix(repo): ... and for including resolves #395 in the PR body.
Opened and read .github/pull_request_template.md to reuse the existing template verbatim for the new PR body, filling in the checkboxes and ### Description to describe the @dot/versioner dependency upgrade and associated verification commands.
Ran pnpm exec versioner --version on chore/repo/update-versioner and observed a TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string from @dot/versioner@0.4.3, confirming a known CLI startup issue when invoked without a project config.
Re-ran pnpm exec versioner --help and saw the same TypeError emitted on stderr with exit code 0 and no stdout, noting this behavior in the planned PR description as a quirk of the upgraded @dot/versioner rather than a repo misconfiguration.
Activity
charliecreates commentedon Jan 10, 2026
Expand this to see my work.
.github/workflows/release.yml,.moon/tasks.yml,.npmrc, andscripts/release-publish.sh, keeping allNPM_TOKEN/NODE_AUTH_TOKENusage removed in line with #395.releasetask in.moon/tasks.ymlso thecommandnow chainsversioner --target "$projectRoot" --publish=false && ../../scripts/release-publish.sh "$projectRoot", ensuringrelease-publish.shonly runs ifversionersucceeds and making failure ordering explicit.scripts/release-publish.shto verifypnpmis available viacommand -v pnpmwith a clear error message before proceeding, then log bothPacking to $PACK_DIRandRunning pnpm pack in $project_rootprior topnpm pack --pack-destination "$PACK_DIR"for better CI debuggability.pnpm exec prettier --check .moon/tasks.ymlto confirm the updated release task YAML stays formatted correctly and executedbash -n scripts/release-publish.shto validate the modified shell script parses cleanly..github/workflows/release.ymlpinsnpm@11.5.1specifically to guaranteenpm publish --provenancesupport on GitHub runners, and thatcontents: writeremains scoped to thereleasejob forversionercommits/tags.scripts/release-publish.shto dropnpxand instead use a pinned npm CLI viapnpm dlx "$NPM_CLI_SPEC" publish --provenance, then validated formatting and shell parsing withpnpm exec prettier --check .github/workflows/release.yml .moon/tasks.ymlandbash -n scripts/release.sh scripts/release-publish.sh.releasetask in.moon/tasks.yml, clarified local auth expectations in.npmrcwith a~/.npmrccomment, expandedscripts/release.shto require bothpnpmandnodein a loop, and re-validated withpnpm exec prettier --check .moon/tasks.ymlplusbash -n scripts/release.sh(both passing).Releasestep in.github/workflows/release.ymlexplaining that npm auth is handled via GitHub OIDC inscripts/release*.sh(noNPM_TOKENneeded), and confirmed formatting viapnpm exec prettier --check .github/workflows/release.yml..github/workflows/release.yml(jobs needing npm OIDC must requestid-token: write), expanding thealways-authexplanation in.npmrcso contributors know they need valid~/.npmrccredentials for private/publish flows, and logging the resolvedNPM_CLI_SPECinscripts/release-publish.shbefore thepnpm dlxpublish call for better CI observability.fix(repo): publish releases to npm via OIDC) containing therelease.yml/.npmrc/.moon/tasks.yml/scripts/release*.shchanges, requested review fromshellscapeandCharlieHelps, and documented the verification steps (pnpm exec prettier --check ...andbash -n scripts/release.sh scripts/release-publish.sh) in the PR body.charliecreates commentedon Jan 10, 2026
Opened PR #396 to switch the release pipeline over to npm OIDC publishing (no classic tokens), per #395.
Changes
.github/workflows/release.ymlto requestid-token: writeat the job level (OIDC) and removedNPM_TOKEN/NODE_AUTH_TOKENusage..npmrc(and added clarifying comments about auth expectations).releasetask to runscripts/release.sh, which:versioner --publish=falsepnpm pack(soworkspace:deps are rewritten)pnpm dlx npm@11.5.1 publish --provenanceusing OIDCALLOW_LOCAL_PUBLISH=1is setNote: for the publish to succeed, npm “Trusted Publisher” / OIDC needs to be configured on the npm side for these packages to allow publishes from this repo/workflow.
Verification
shellscape commentedon Jan 11, 2026
@CharlieHelps see the error logs in this attempted publish https://github.com/shellscape/jsx-email/actions/runs/20900410369/job/60045408544
Then examine the
versionersource code here https://github.com/shellscape/dot/tree/master/packages/versioner.Triage why this workflow failed and report in a comment in this issue.
charliecreates commentedon Jan 11, 2026
Expand this to see my work.
Release Projectsrun linked from issue #395 to understand at which step the publish attempt stopped and what error surfaced.versionerusage and confirmed the Moon task wiring in.moon/tasks.yml, where thereleasetask runsversioner --target $projectRootafter~:build.releasetask configuration in.moon/tasks.ymlto see that it disables caching and runs dependencies serially, which helps narrow down whether the failure is in build vs. theversionerinvocation itself.f6391f3e3a8de5429d22101e47e184d7263dec01viagh api, confirming it corresponds to "chore(jsx-email): upgrade react-router-dom to 7.12.0 (chore: upgrade react-router-dom to 7.12.0 #394)" and identifying its parent1232d5ff5ff67e90e14cf02f1ec46183c10c4739for context on what@dot/versionerwas diffing against.shellscape/dotlocally and verified the layout ofpackages/versionerto work against the current@dot/versionerimplementation.packages/versioner/srcforpublishusage and located thepublishhelper plus its invocation withinversioner.ts.argvparsing inpackages/versioner/src/versioner.tsto see thatpublishandpushbehavior are controlled viayargs-parserflags (dry,publish,push,tag).publishfunction inpackages/versioner/src/versioner.tsand confirmed it callspnpm publish --no-git-checksunless--dryis passed or--publish=falseis explicitly set on the CLI, in which case it logs{yellow Skipping Publish}instead..github/workflowsat commitf6391f3e3a8de5429d22101e47e184d7263dec01and then listed the local.github/workflowsdirectory to confirm thatrelease.ymlis the workflow referenced by the failingRelease Projectsrun..github/workflows/release.ymlat commitf6391f3e3a8de5429d22101e47e184d7263dec01, confirming theRelease Projectsjob checks outref: main, runsmoon jsx-email:buildplus other builds, performs anOIDC Preflightcheck, and then triggersmoon run :release --affected --concurrency 1 --remote, which is the entry point that ultimately calls@dot/versioner.charliecreates commentedon Jan 11, 2026
#395 (comment)
Pulled the failed logs from the
Release Projectsrun (job60045408544). The failure is coming fromversionertrying to publish viapnpm publish, which (unlike the npm CLI) can’t use GitHub’s OIDC “Trusted Publisher” flow—so with classic tokens removed, it just hard-fails with missing auth.In the job log,
jsx-email:releasereaches:Publishing to NPMpnpm publish --no-git-checksnpm error code ENEEDAUTH/ “need auth … npm adduser”, andversionerexits non-zero.This matches
versioner’s implementation inshellscape/dot:packages/versioner/src/versioner.tshaspublish()callingexeca('pnpm', ['publish', '--no-git-checks'], ...)unless--publish=falseis passed. (See around here:packages/versioner/src/versioner.tslines ~148–160 in that repo.)So, even though the workflow is already requesting
id-token: write(OIDC), the actual publish path being executed (pnpm publish) never uses it.What needs to change (in this repo):
versionerwith publishing disabled (--publish=false), and then publish with the npm CLI (e.g.npm publish --provenance) in a separate step/script.versioner --target $projectRoot(no--publish=false), which is why we’re hittingpnpm publish.Smaller sidenote: Moon is also warning about a shallow checkout when doing
--affected, but that’s not the cause of this publish failure.shellscape commentedon Jan 11, 2026
@CharlieHelps please consult the pnpm documentation to double check if it doesnt support oidc. I'm pretty sure it does, so there's another reason why pnpm publish isnt working with oidc
charliecreates commentedon Jan 11, 2026
Expand this to see my work.
pnpm publishauthenticates in CI environments.pnpm publishwith GitHub Actions OIDC workflows in jsx-email.charliecreates commentedon Jan 11, 2026
#395 (comment)
Double-checked pnpm’s docs + upstream threads:
pnpm publishdoes document--provenance, but it doesn’t document npm “Trusted Publisher” / GitHub OIDC auth support (it still reads like it expects normal registry auth via.npmrc).On the npm side, OIDC “Trusted Publisher” publishing is currently described as an npm CLI feature (and npm calls out the need for a sufficiently new npm CLI).
Also notable: pnpm upstream has an (as of now) draft PR explicitly trying to add OIDC publishing support by letting pnpm download/use a particular npm CLI for publishing (which strongly suggests this isn’t generally supported in released pnpm yet).
So the
ENEEDAUTHwe saw fromversionerrunningpnpm publishstill lines up with “no token auth present, and OIDC isn’t kicking in for pnpm publish”.This is why the fix in #396 (merged) switched to
versioner --publish=false+npm publish(viapnpm dlx npm@…) for the actual publish step.shellscape commentedon Jan 11, 2026
@CharlieHelps don't be lazy. pnpm/pnpm#9812
charliecreates commentedon Jan 11, 2026
Reviewing the new comment on issue #395 to understand the context and what response or action is actually needed.
charliecreates commentedon Jan 11, 2026
Expand this to see my work.
jsx-emailwork.gh pr view 396, saw the command fail due to requesting an unsupportedmergedJSON field, and confirmed this doesn’t change the underlying work on the npm publishing strategy.pnpmsettings documentation athttps://pnpm.io/settingswith a search fornpmVersion/npmPath, confirmednpmPathis documented as a configurable setting, and noted there is no first-classnpmVersionsetting exposed there for pinning.pnpm-workspace.yamldocs athttps://pnpm.io/pnpm-workspace_yamlfornpmVersion/npmPathand confirmed there is no workspace-level configuration for these, reinforcing that any npm pinning will likely live in scripts or CI tooling rather than workspace config.charliecreates commentedon Jan 11, 2026
#395 (comment)
Looked at pnpm/pnpm#9812 — it’s explicitly a feature request to support npm “trusted publishing” (OIDC), and it points at pnpm/pnpm#10092 as the upstream work to make
pnpm publishuse a specific npm CLI for publishing.That lines up with the failure we saw:
versionerwas invokingpnpm publish ...and hittingENEEDAUTHbecause the OIDC support lives in the npm CLI (and npm notes it requiresnpm>= 11.5.1). In other words:pnpm publishwon’t “just work” with OIDC unless it’s actually running an OIDC-capable npm under the hood (and is configured to do so).That’s also why the fix in PR #396 went with
versioner --publish=false+pnpm dlx npm@11.5.1 publish --provenanceinscripts/release-publish.sh: it guarantees the correct npm CLI is what performs the publish step.shellscape commentedon Jan 11, 2026
@CharlieHelps I see. You have been added to the shellscape/dot repository. Please open a PR on that repository for changing the publish command to use
npminstead ofpnpmwithin the versioner package. Also update the repo to use OIDC following the changes you made to this (jsx-email) repository as well.charliecreates commentedon Jan 11, 2026
Reviewing the new comment on issue #395 and scoping the work for a PR to
shellscape/dot.charliecreates commentedon Jan 11, 2026
Expand this to see my work.
shellscape/dotrepo into the workspace and inspected.github/workflows/release.ymlto understand the existingpnpm-based publish flow andNPM_TOKENusage.Release and Publish Changed Packagesstep plus rootpackage.jsonandpackages/**/package.jsonto see how@dot/versioneris invoked and how workspace packages are published.packages/versioner/src/versioner.tsand confirmed it previously calledexeca('pnpm', ['publish', '--no-git-checks'], { cwd, stdio: 'inherit' });as the core publish path.jsx-email's release workflow and.github/actions/setup/action.ymlto mirror the Node 20 +actions/setup-node+id-token: writeOIDC pattern for npm Trusted Publisher.fix/versioner/npm-oidc-publishbranch inshellscape/dotto isolate changes for switching@dot/versionertonpm publishwith OIDC.packages/versioner/src/versioner.tssopublishnowpnpm packs to a temp dir, detects OIDC viaACTIONS_ID_TOKEN_REQUEST_*, and then runspnpm dlx npm@11.5.1 publish --no-git-checks [--provenance] <tarball>, with anNPM_CLI_SPECconstant and temp-dir cleanup viarmSyncin afinallyblock, plus import tweaks (mkdtempSync,readdirSync,rmSync,tmpdir) to satisfy ESLint..npmrcto dropNPM_TOKEN-based auth and document that CI publishing uses npm Trusted Publisher via GitHub OIDC while local publishes rely on the developer’s~/.npmrc..github/workflows/release.ymlto useactions/checkout@v4,actions/setup-node@v4with Node 20, declarepermissions(includingid-token: write), add anOIDC Preflightstep, shiftpnpm/action-setup@v4earlier, and removeNODE_AUTH_TOKEN/NPM_TOKENfrom theRelease and Publish Changed Packagesstep, then ranpnpm lintto confirm formatting/linting pass aside from an existingpackages/cdk/src/methods/security.tswarning.pnpm install --frozen-lockfile, ranpnpm -r buildandAWS_REGION='us-east-1' pnpm --filter "...[origin/master]" testto validate the updated flow, and spot-checkedpackages/*/package.jsonto confirm@dot/access,@dot/config, and@dot/logall still runFORCE_COLOR=2 ava.fix(repo,versioner): publish with npm via OIDC, pushedfix/versioner/npm-oidc-publishto GitHub, and reviewed.github/PULL_REQUEST_TEMPLATE.mdplus recent merged PRs to align the upcoming PR title/body with the repo’s conventions.charliecreates commentedon Jan 11, 2026
#395 (comment)
Opened a PR on
shellscape/dotto switch@dot/versionerpublishing over to thenpmCLI (OIDC/Trusted Publisher compatible) and update the repo release workflow accordingly: shellscape/dot#6Changes (dot)
@dot/versioner: replacedpnpm publishwithpnpm pack+pnpm dlx npm@11.5.1 publish(adds--provenanceautomatically when the GitHub OIDC env vars are present)..npmrc) and updated.github/workflows/release.ymlto requestid-token: write(and removedNPM_TOKEN/NODE_AUTH_TOKEN).Verification (dot)
$ pnpm install --frozen-lockfile $ pnpm -r build $ pnpm lint $ AWS_REGION=us-east-1 pnpm -r test --if-presentshellscape commentedon Jan 11, 2026
@CharlieHelps versioner has been updated. open a new PR to update that dep
charliecreates commentedon Jan 11, 2026
Expand this to see my work.
git status --porcelain=v1onchore/repo/update-versionerand found a large set of untracked TypeScript emit artifacts underpackages/jsx-email/src/**created byjsx-email:tsc.packages/jsx-email/tsconfig.jsonand confirmed it extends../../shared/tsconfig.base.jsonand includessrc/**/*.ts/src/**/*.d.ts, which explains whytscemits intosrcwhen run directly.git clean -fd packages/jsx-email/src, removing the compiled.js,.d.ts, and.mapfiles so they don’t pollute the new PR diff.git status --porcelain=v1and verified the working tree is now clean, with only the intended@dot/versionerand snapshot updates tracked onchore/repo/update-versioner.gh pr list --state merged --limit 10to confirm conventions for titles likechore: .../fix(repo): ...and for includingresolves #395in the PR body..github/pull_request_template.mdto reuse the existing template verbatim for the new PR body, filling in the checkboxes and### Descriptionto describe the@dot/versionerdependency upgrade and associated verification commands.pnpm exec versioner --versiononchore/repo/update-versionerand observed aTypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type stringfrom@dot/versioner@0.4.3, confirming a known CLI startup issue when invoked without a project config.pnpm exec versioner --helpand saw the sameTypeErroremitted on stderr with exit code 0 and no stdout, noting this behavior in the planned PR description as a quirk of the upgraded@dot/versionerrather than a repo misconfiguration.charliecreates commentedon Jan 11, 2026
#395 (comment)
Opened PR #400 to bump
@dot/versionerto the latest published version: #400Changes
@dot/versionerfrom^0.3.4→^0.4.3(rootpackage.json+pnpm-lock.yaml).jsx-emailconfig snapshots that changed due to pnpm deduping@dot/log(pulled in by the new@dot/versioner).Verification
fix(release): use npm directly for OIDC trusted publishing