feat: add --warmup auto to detect stable warmup count (fixes #848) - #892
Closed
wyf027 wants to merge 1 commit into
Closed
feat: add --warmup auto to detect stable warmup count (fixes #848)#892wyf027 wants to merge 1 commit into
wyf027 wants to merge 1 commit into
Conversation
Allow `--warmup auto` to keep performing warmup runs until the relative spread of the last five runs is at most 1%, capped at 100 iterations. Existing numeric `--warmup` behavior is unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #848.
Adds support for
--warmup auto, which keeps performing warmup runs until the relative spread of the last 5 warmup timings is at most 1%. Warmup stops early once stable, or after 100 runs at most.Numeric
--warmup NUMbehavior is unchanged.Changes
WarmupOption(Disabled,Fixed,Auto) replacing the rawwarmup_count--warmup autoin CLI/optionsTest plan
cargo test warmupcargo test test_parse_warmup_option test_is_warmup_stablecargo testMade with Cursor