Fix misaligned "No content" line for non-default --panels and --border - #283
Open
upuddu wants to merge 1 commit into
Open
Fix misaligned "No content" line for non-default --panels and --border#283upuddu wants to merge 1 commit into
upuddu wants to merge 1 commit into
Conversation
The "No content" line printed for empty input hardcoded two hex panels, two character panels and the Unicode separator. As a result it did not line up with the surrounding border for any other `--panels` count and ignored `--border=ascii`/`--border=none`. Build the line from the actual panel count and border separator instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
No contentline shown for empty input assumed exactly two panels and the Unicode border, so it didn't line up with the box for other--panelscounts and ignored--border=ascii/--border=none. This builds the line from the actual panel count and the active border separator; the default two-panel output is byte-for-byte unchanged.