fix: allow hyphen-leading --format templates - #2127
Merged
Merged
Conversation
Clap treated a space-separated --format value that starts with '-' as a new flag. Enable allow_hyphen_values for --format (same as --and) and add a regression covering markdown-list-style templates. See sharkdp#2126. Signed-off-by: Jason Wang <vulragrag@gmail.com>
tmccombs
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--formatvalues that start with-were rejected when passed as a separate argument (fd --format "- {/.}"), while the=form worked. Clap treated the value as a new flag. Enableallow_hyphen_valuesfor--format(same treatment as--and) so markdown-list-style templates work as documented.Fixes #2126
Test plan
tests/tests.rsfor--format "- {/.}"Notes
AI coding assistance was used to help locate the clap option and draft the patch; I reviewed the change, wrote/adjusted the regression, and verified CI.
Signed-off-by: Jason Wang vulragrag@gmail.com