feat: add --no-ignore-vcs-exclude / --ignore-vcs-exclude - #2103
Open
patnr wants to merge 2 commits into
Open
Conversation
Completes PR sharkdp#1652 as requested in review: adds integration tests (including interaction with --no-ignore-vcs, --no-ignore and -u), a CHANGELOG entry, the man page entry, the zsh completion entry, and fixes two typos in the --no-ignore-vcs-exclude long help. This commit was written with an AI coding assistant (Claude Code). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1612. Supersedes #1652 — this takes @AckslD's original commit (rebased onto current master) and completes the review feedback from that PR.
Adds
--no-ignore-vcs-exclude, which shows results that would otherwise be ignored by.git/info/excludewhile still respecting.gitignoreand other ignore files. The motivation (from #1612) is that these two kinds of ignore files tend to serve different purposes:.gitignoreis committed and typically lists generated or automatic files that nobody wants to see, while.git/info/excludeis often used for personal files that you actively use and do want to find — you just don't want to commit them or impose them on the repo. This flag lets you keep those personal files visible in searches without giving up gitignore filtering entirely.--ignore-vcs-excludeoverrides it, following the existing flag-pair convention.On top of the original commit: integration tests (including interaction with
--no-ignore-vcs,--no-ignore, and-u, plus an override-pair case), CHANGELOG entry, man page entry, zsh completion entry, and two typo fixes in the flag's long help.AI disclosure (per the contributing guide): the follow-up commit (tests, docs, changelog, typo fixes) was written with an AI coding assistant (Claude Code) under my direction, and I have reviewed the changes. The original feature commit is human-written by @AckslD.
🤖 Generated with Claude Code