fix: prevent Windows subprocess output decode crashes - #510
Merged
Bill-Billion merged 3 commits intoAug 25, 2026
Conversation
…-output # Conflicts: # s07_skill_loading/code.py
Collaborator
|
Thanks for identifying and reproducing the Windows decoding failure. I merged the latest main and extended the fix across all lesson and reference subprocess paths, with regression coverage and full Python, web-build, and real-model verification now passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
subprocess.runandsubprocess.Popendecode text output with the platform's active encoding and strict error handling by default. On Windows, mixed or malformed command output can therefore raiseUnicodeDecodeError; the original UTF-8-to-GBK fallback still raised for bytes invalid in both codecs and only covereds07.Solution
errors="replace".Verification
python -m pytest tests -q: 287 passed, 100 subtests passednpm run build: passed�, message roles remained valid, and the model completed normally