feat: add katana chain - #779
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughAdds a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
NeOMakinG
left a comment
NeOMakinG
left a comment
There was a problem hiding this comment.
Easy for this one!
Testing the web side right now, but we can already accept this one for sure
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Fix all issues with AI Agents 🤖
In @packages/hdwallet-keepkey-tcp/package.json:
- Line 19: The package.json currently pins "axios": "^0.21.1", which is
vulnerable; update that dependency to a non-vulnerable version (at minimum
"axios": ">=0.21.3", preferably a modern 1.x release like "^1.4.0" or the latest
stable), then regenerate the lockfile by running your package manager (npm
install or yarn install) so package-lock.json/yarn.lock is updated; finally run
npm audit (or yarn audit) and the test suite to ensure no regressions.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (27)
examples/sandbox/package.jsonintegration/package.jsonlerna.jsonpackages/hdwallet-coinbase/package.jsonpackages/hdwallet-core/package.jsonpackages/hdwallet-gridplus/package.jsonpackages/hdwallet-keepkey-chromeusb/package.jsonpackages/hdwallet-keepkey-electron/package.jsonpackages/hdwallet-keepkey-nodehid/package.jsonpackages/hdwallet-keepkey-nodewebusb/package.jsonpackages/hdwallet-keepkey-tcp/package.jsonpackages/hdwallet-keepkey-webusb/package.jsonpackages/hdwallet-keepkey/package.jsonpackages/hdwallet-keplr/package.jsonpackages/hdwallet-ledger-webhid/package.jsonpackages/hdwallet-ledger-webusb/package.jsonpackages/hdwallet-ledger/package.jsonpackages/hdwallet-metamask-multichain/package.jsonpackages/hdwallet-native-vault/package.jsonpackages/hdwallet-native/package.jsonpackages/hdwallet-phantom/package.jsonpackages/hdwallet-portis/package.jsonpackages/hdwallet-trezor-connect/package.jsonpackages/hdwallet-trezor/package.jsonpackages/hdwallet-vultisig/package.jsonpackages/hdwallet-walletconnect/package.jsonpackages/hdwallet-walletconnectV2/package.json
✅ Files skipped from review due to trivial changes (2)
- lerna.json
- packages/hdwallet-walletconnect/package.json
🧰 Additional context used
🧠 Learnings (9)
📓 Common learnings
Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 769
File: packages/hdwallet-walletconnectV2/src/walletconnectV2.ts:150-152
Timestamp: 2025-12-12T11:20:00.907Z
Learning: In the shapeshift/hdwallet monorepo, the `ethSupportsNetwork()` method in wallet implementations is a legacy/relic method that is no longer used. Chain support is determined by the `_supports*` flags (e.g., `_supportsMonad`, `_supportsPlasma`, `_supportsHyperEvm`) on the wallet classes, not by the `ethSupportsNetwork()` method.
Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 778
File: packages/hdwallet-walletconnect/src/walletconnect.ts:132-132
Timestamp: 2026-01-03T12:07:36.693Z
Learning: The packages/hdwallet-walletconnect package (WalletConnect v1) is a legacy package where all chain support flags should remain false, including _supportsAvalanche, _supportsOptimism, _supportsBSC, _supportsPolygon, _supportsGnosis, _supportsArbitrum, _supportsArbitrumNova, _supportsBase, _supportsMonad, _supportsPlasma, _supportsHyperEvm, and _supportsMegaEth.
Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 769
File: packages/hdwallet-ledger/src/ledger.ts:403-405
Timestamp: 2025-12-12T11:19:53.179Z
Learning: In packages/hdwallet-ledger/src/ethereum.ts, the ethSupportsNetwork function is a legacy/unused function that only returns true for chainId === 1. The Ledger ETH module does not call ethSupportsNetwork to validate chain support during signing operations - it accepts any chainId passed in the ETHSignTx message directly, so chain support flags can be enabled without needing to update ethSupportsNetwork.
📚 Learning: 2025-08-07T15:23:54.858Z
Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-coinbase/package.json:18-18
Timestamp: 2025-08-07T15:23:54.858Z
Learning: In the shapeshiftoss/hdwallet monorepo, package version bumps are done in PRs before publishing. The packages are published after the PR is merged, so dependency versions may reference unpublished versions during the PR review phase. This is expected behavior in their release workflow.
Applied to files:
packages/hdwallet-native-vault/package.jsonpackages/hdwallet-keepkey-webusb/package.jsonpackages/hdwallet-trezor/package.jsonpackages/hdwallet-keepkey-nodehid/package.jsonpackages/hdwallet-core/package.jsonpackages/hdwallet-walletconnectV2/package.jsonpackages/hdwallet-keepkey-nodewebusb/package.jsonpackages/hdwallet-metamask-multichain/package.jsonpackages/hdwallet-vultisig/package.jsonpackages/hdwallet-keplr/package.jsonpackages/hdwallet-coinbase/package.jsonpackages/hdwallet-ledger-webhid/package.jsonpackages/hdwallet-native/package.jsonpackages/hdwallet-keepkey-electron/package.jsonpackages/hdwallet-ledger-webusb/package.jsonpackages/hdwallet-portis/package.jsonpackages/hdwallet-ledger/package.jsonpackages/hdwallet-keepkey-chromeusb/package.jsonexamples/sandbox/package.jsonpackages/hdwallet-gridplus/package.jsonpackages/hdwallet-keepkey-tcp/package.jsonpackages/hdwallet-trezor-connect/package.jsonpackages/hdwallet-keepkey/package.jsonpackages/hdwallet-phantom/package.jsonintegration/package.json
📚 Learning: 2025-08-07T15:27:03.179Z
Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-ledger/package.json:36-36
Timestamp: 2025-08-07T15:27:03.179Z
Learning: In the shapeshiftoss/hdwallet monorepo, the ledgerhq/hw-transport dependency in packages/hdwallet-ledger/package.json is pinned to an exact version (without caret) due to type mismatches that occur with newer versions. Other Ledger dependencies can safely use caret ranges.
Applied to files:
packages/hdwallet-native-vault/package.jsonpackages/hdwallet-keepkey-webusb/package.jsonpackages/hdwallet-trezor/package.jsonpackages/hdwallet-keepkey-nodehid/package.jsonpackages/hdwallet-core/package.jsonpackages/hdwallet-walletconnectV2/package.jsonpackages/hdwallet-keepkey-nodewebusb/package.jsonpackages/hdwallet-metamask-multichain/package.jsonpackages/hdwallet-vultisig/package.jsonpackages/hdwallet-keplr/package.jsonpackages/hdwallet-coinbase/package.jsonpackages/hdwallet-ledger-webhid/package.jsonpackages/hdwallet-native/package.jsonpackages/hdwallet-keepkey-electron/package.jsonpackages/hdwallet-ledger-webusb/package.jsonpackages/hdwallet-portis/package.jsonpackages/hdwallet-ledger/package.jsonpackages/hdwallet-keepkey-chromeusb/package.jsonexamples/sandbox/package.jsonpackages/hdwallet-gridplus/package.jsonpackages/hdwallet-keepkey-tcp/package.jsonpackages/hdwallet-trezor-connect/package.jsonpackages/hdwallet-keepkey/package.jsonpackages/hdwallet-phantom/package.jsonintegration/package.json
📚 Learning: 2025-08-07T15:24:19.530Z
Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-ledger-webusb/package.json:3-3
Timestamp: 2025-08-07T15:24:19.530Z
Learning: In the shapeshiftoss/hdwallet monorepo, the team runs `yarn build` before bumping versions and also before publishing packages. This ensures that dist/ artifacts (including UMD bundles) are properly regenerated after dependency updates.
Applied to files:
packages/hdwallet-native-vault/package.jsonpackages/hdwallet-keepkey-webusb/package.jsonpackages/hdwallet-trezor/package.jsonpackages/hdwallet-keepkey-nodehid/package.jsonpackages/hdwallet-core/package.jsonpackages/hdwallet-walletconnectV2/package.jsonpackages/hdwallet-keepkey-nodewebusb/package.jsonpackages/hdwallet-metamask-multichain/package.jsonpackages/hdwallet-vultisig/package.jsonpackages/hdwallet-keplr/package.jsonpackages/hdwallet-coinbase/package.jsonpackages/hdwallet-ledger-webhid/package.jsonpackages/hdwallet-native/package.jsonpackages/hdwallet-keepkey-electron/package.jsonpackages/hdwallet-ledger-webusb/package.jsonpackages/hdwallet-portis/package.jsonpackages/hdwallet-ledger/package.jsonpackages/hdwallet-keepkey-chromeusb/package.jsonexamples/sandbox/package.jsonpackages/hdwallet-gridplus/package.jsonpackages/hdwallet-keepkey-tcp/package.jsonpackages/hdwallet-trezor-connect/package.jsonpackages/hdwallet-keepkey/package.jsonpackages/hdwallet-phantom/package.jsonintegration/package.json
📚 Learning: 2025-12-09T13:48:55.139Z
Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 764
File: packages/hdwallet-gridplus/package.json:0-0
Timestamp: 2025-12-09T13:48:55.139Z
Learning: In the shapeshiftoss/hdwallet monorepo, the dist/ directory is not version controlled (not tracked in git). Build artifacts are generated during the build/publish workflow, not committed to the repository.
Applied to files:
packages/hdwallet-native-vault/package.jsonpackages/hdwallet-keepkey-webusb/package.jsonpackages/hdwallet-trezor/package.jsonpackages/hdwallet-keepkey-nodehid/package.jsonpackages/hdwallet-core/package.jsonpackages/hdwallet-walletconnectV2/package.jsonpackages/hdwallet-keepkey-nodewebusb/package.jsonpackages/hdwallet-metamask-multichain/package.jsonpackages/hdwallet-vultisig/package.jsonpackages/hdwallet-keplr/package.jsonpackages/hdwallet-coinbase/package.jsonpackages/hdwallet-ledger-webhid/package.jsonpackages/hdwallet-native/package.jsonpackages/hdwallet-keepkey-electron/package.jsonpackages/hdwallet-ledger-webusb/package.jsonpackages/hdwallet-portis/package.jsonpackages/hdwallet-ledger/package.jsonpackages/hdwallet-keepkey-chromeusb/package.jsonexamples/sandbox/package.jsonpackages/hdwallet-gridplus/package.jsonpackages/hdwallet-keepkey-tcp/package.jsonpackages/hdwallet-trezor-connect/package.jsonpackages/hdwallet-keepkey/package.jsonpackages/hdwallet-phantom/package.jsonintegration/package.json
📚 Learning: 2025-08-07T15:47:29.207Z
Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-ledger/src/transport.ts:10-10
Timestamp: 2025-08-07T15:47:29.207Z
Learning: In the shapeshiftoss/hdwallet monorepo, ts-ignore is used instead of ts-expect-error for Ledger transport imports because the code works locally without TypeScript errors but has issues in CI environment. Using ts-expect-error would fail locally since there are no actual errors to suppress.
Applied to files:
packages/hdwallet-native-vault/package.jsonpackages/hdwallet-keepkey-webusb/package.jsonpackages/hdwallet-trezor/package.jsonpackages/hdwallet-keepkey-nodehid/package.jsonpackages/hdwallet-core/package.jsonpackages/hdwallet-walletconnectV2/package.jsonpackages/hdwallet-keepkey-nodewebusb/package.jsonpackages/hdwallet-metamask-multichain/package.jsonpackages/hdwallet-vultisig/package.jsonpackages/hdwallet-keplr/package.jsonpackages/hdwallet-coinbase/package.jsonpackages/hdwallet-ledger-webhid/package.jsonpackages/hdwallet-native/package.jsonpackages/hdwallet-keepkey-electron/package.jsonpackages/hdwallet-ledger-webusb/package.jsonpackages/hdwallet-portis/package.jsonpackages/hdwallet-ledger/package.jsonpackages/hdwallet-keepkey-chromeusb/package.jsonexamples/sandbox/package.jsonpackages/hdwallet-gridplus/package.jsonpackages/hdwallet-keepkey-tcp/package.jsonpackages/hdwallet-trezor-connect/package.jsonpackages/hdwallet-keepkey/package.jsonpackages/hdwallet-phantom/package.jsonintegration/package.json
📚 Learning: 2025-08-07T15:47:26.835Z
Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-ledger-webusb/src/transport.ts:12-12
Timestamp: 2025-08-07T15:47:26.835Z
Learning: In the shapeshiftoss/hdwallet monorepo, ts-ignore is used instead of ts-expect-error for Ledger transport imports because the CI environment has different type checking behavior than local development. The code works locally without errors, but CI reports type issues, so ts-ignore is necessary to suppress the inconsistent type checking across environments.
Applied to files:
packages/hdwallet-native-vault/package.jsonpackages/hdwallet-keepkey-webusb/package.jsonpackages/hdwallet-trezor/package.jsonpackages/hdwallet-keepkey-nodehid/package.jsonpackages/hdwallet-walletconnectV2/package.jsonpackages/hdwallet-keepkey-nodewebusb/package.jsonpackages/hdwallet-metamask-multichain/package.jsonpackages/hdwallet-vultisig/package.jsonpackages/hdwallet-keplr/package.jsonpackages/hdwallet-coinbase/package.jsonpackages/hdwallet-ledger-webhid/package.jsonpackages/hdwallet-native/package.jsonpackages/hdwallet-keepkey-electron/package.jsonpackages/hdwallet-ledger-webusb/package.jsonpackages/hdwallet-portis/package.jsonpackages/hdwallet-ledger/package.jsonpackages/hdwallet-keepkey-chromeusb/package.jsonexamples/sandbox/package.jsonpackages/hdwallet-gridplus/package.jsonpackages/hdwallet-keepkey-tcp/package.jsonpackages/hdwallet-trezor-connect/package.jsonpackages/hdwallet-keepkey/package.jsonpackages/hdwallet-phantom/package.jsonintegration/package.json
📚 Learning: 2026-01-03T12:07:36.693Z
Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 778
File: packages/hdwallet-walletconnect/src/walletconnect.ts:132-132
Timestamp: 2026-01-03T12:07:36.693Z
Learning: The packages/hdwallet-walletconnect package (WalletConnect v1) is a legacy package where all chain support flags should remain false, including _supportsAvalanche, _supportsOptimism, _supportsBSC, _supportsPolygon, _supportsGnosis, _supportsArbitrum, _supportsArbitrumNova, _supportsBase, _supportsMonad, _supportsPlasma, _supportsHyperEvm, and _supportsMegaEth.
Applied to files:
packages/hdwallet-trezor/package.jsonpackages/hdwallet-walletconnectV2/package.jsonpackages/hdwallet-metamask-multichain/package.jsonpackages/hdwallet-keplr/package.jsonpackages/hdwallet-coinbase/package.jsonpackages/hdwallet-ledger-webhid/package.jsonpackages/hdwallet-native/package.jsonexamples/sandbox/package.jsonpackages/hdwallet-gridplus/package.jsonpackages/hdwallet-keepkey/package.json
📚 Learning: 2025-12-12T11:20:00.907Z
Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 769
File: packages/hdwallet-walletconnectV2/src/walletconnectV2.ts:150-152
Timestamp: 2025-12-12T11:20:00.907Z
Learning: In the shapeshift/hdwallet monorepo, the `ethSupportsNetwork()` method in wallet implementations is a legacy/relic method that is no longer used. Chain support is determined by the `_supports*` flags (e.g., `_supportsMonad`, `_supportsPlasma`, `_supportsHyperEvm`) on the wallet classes, not by the `ethSupportsNetwork()` method.
Applied to files:
packages/hdwallet-trezor/package.jsonpackages/hdwallet-coinbase/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build and Release
🔇 Additional comments (25)
packages/hdwallet-keepkey-webusb/package.json (1)
3-3: LGTM! Version bumps are consistent and properly coordinated.The package version and dependency versions are all aligned at 1.62.37, maintaining consistency across the monorepo for this Katana chain support release.
Also applies to: 17-18
packages/hdwallet-phantom/package.json (1)
3-3: LGTM! Version bumps are correctly aligned.The package version and the
@shapeshiftoss/hdwallet-coredependency are both updated to 1.62.37, which aligns with the PR adding Katana chain support.Also applies to: 18-18
packages/hdwallet-portis/package.json (1)
3-3: LGTM! Version bumps are consistent and properly synchronized.The package version and core dependency are correctly bumped in lockstep (1.62.36 → 1.62.37), which aligns with the monorepo's coordinated release pattern for adding Katana chain support.
Also applies to: 19-19
packages/hdwallet-trezor-connect/package.json (1)
3-3: LGTM! Version bumps are consistent.The package version and internal dependencies are consistently bumped to 1.62.37, aligning with the monorepo-wide Katana chain support update. The dependency pattern correctly uses exact versions for internal packages and caret for external dependencies.
Also applies to: 17-18
examples/sandbox/package.json (1)
3-33: LGTM! Version bumps are consistent.All package and dependency versions are correctly updated to 1.62.37, aligning with the monorepo-wide version bump for the Katana chain support feature.
packages/hdwallet-core/package.json (1)
3-3: LGTM! Core package version updated.The hdwallet-core package version is correctly bumped to 1.62.37, consistent with the monorepo-wide release.
packages/hdwallet-vultisig/package.json (1)
3-20: LGTM! Version and dependency updates are correct.Both the package version and hdwallet-core dependency are properly updated to 1.62.37.
packages/hdwallet-metamask-multichain/package.json (1)
3-20: LGTM! Consistent version alignment.Package version and hdwallet-core dependency are both correctly updated to 1.62.37.
packages/hdwallet-ledger-webhid/package.json (1)
3-22: LGTM! All version updates are properly aligned.Package version and both hdwallet dependencies (hdwallet-core and hdwallet-ledger) are correctly updated to 1.62.37.
integration/package.json (1)
3-23: LGTM - Coordinated monorepo version bump.The version bump to 1.62.37 and the alignment of all hdwallet dependencies are consistent with the monorepo's release workflow. Based on learnings, version bumps in PRs before publishing is expected behavior.
packages/hdwallet-ledger/package.json (1)
3-31: LGTM - Version alignment with core dependency.The package version and hdwallet-core dependency are correctly aligned at 1.62.37, consistent with the monorepo release.
packages/hdwallet-trezor/package.json (1)
3-20: LGTM - Version alignment with core dependency.The package version and hdwallet-core dependency are correctly aligned at 1.62.37.
packages/hdwallet-coinbase/package.json (1)
3-18: LGTM - Version alignment with core dependency.The package version and hdwallet-core dependency are correctly aligned at 1.62.37.
packages/hdwallet-ledger-webusb/package.json (1)
3-24: LGTM - Version alignment with dependencies.The package version and both hdwallet-core and hdwallet-ledger dependencies are correctly aligned at 1.62.37.
packages/hdwallet-walletconnectV2/package.json (1)
3-3: LGTM! Version bump is consistent and properly aligned.The package version and hdwallet-core dependency are both correctly updated to 1.62.37, maintaining alignment across the monorepo for the Katana chain support feature.
Also applies to: 18-18
packages/hdwallet-native/package.json (1)
3-3: LGTM! Version bump is consistent and properly aligned.The package version and hdwallet-core dependency are both correctly updated to 1.62.37, maintaining proper version alignment across the monorepo.
Also applies to: 21-21
packages/hdwallet-keepkey/package.json (1)
3-3: LGTM! Version bump is consistent and properly aligned.The package version and hdwallet-core dependency are both correctly updated to 1.62.37, maintaining alignment across the monorepo.
Also applies to: 24-24
packages/hdwallet-keplr/package.json (1)
3-3: LGTM! Version bump is consistent and properly aligned.The package version and hdwallet-core dependency are both correctly updated to 1.62.37, maintaining alignment across the monorepo.
Also applies to: 20-20
packages/hdwallet-native-vault/package.json (1)
3-3: LGTM! Version bump is consistent and properly aligned.The package version and hdwallet-native dependency are both correctly updated to 1.62.37, maintaining alignment across the monorepo.
Also applies to: 18-18
packages/hdwallet-keepkey-nodehid/package.json (1)
3-3: LGTM! Coordinated version bump.The version and dependency updates are consistent with the monorepo's release workflow for the Katana chain support feature.
Also applies to: 17-17
packages/hdwallet-keepkey-electron/package.json (1)
3-3: LGTM! Coordinated version bump.The version and dependency updates are consistent with the monorepo's release workflow for the Katana chain support feature.
Also applies to: 17-17
packages/hdwallet-gridplus/package.json (1)
3-3: LGTM! Coordinated version bump.The version and dependency updates are consistent with the monorepo's release workflow for the Katana chain support feature.
Also applies to: 23-23
packages/hdwallet-keepkey-chromeusb/package.json (1)
3-3: LGTM! Coordinated version bump.The version and dependency updates are consistent with the monorepo's release workflow for the Katana chain support feature.
Also applies to: 17-18
packages/hdwallet-keepkey-nodewebusb/package.json (1)
3-3: LGTM! Version bumps are consistent.The package version and dependency versions are all consistently updated to 1.62.37, maintaining proper synchronization across the monorepo. Since this is a transport layer package, the actual Katana chain support implementation would be in the hdwallet-core and hdwallet-keepkey dependencies.
Also applies to: 17-18
packages/hdwallet-keepkey-tcp/package.json (1)
3-3: LGTM! Version bumps are consistent.The package version and internal dependencies are correctly synchronized to 1.62.37.
Also applies to: 17-18
2 participants
Because why not?
hdwallet fren of shapeshift/web#11569
https://jam.dev/c/27146c48-4262-47e9-aaf1-d161cbe368b9
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.