Repository navigation
Conversation
Fixes shadone#5 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks
tooming
added a commit
to tooming/keebridge
that referenced
this pull request
Sep 11, 2026
…ew (#112) Fresh audit angles this cycle: three previously-unaudited small app-layer files (ContentView.swift, KeeBridgeApp.swift, LockedView.swift), KeychainStore.swift, KeeBridgeConfig.swift, VaultReadableContent.swift (full reads), a full three-target project.yml-vs.-physical-file diff, a re-read of .github/workflows/ci.yml, and a re-check of issue #89's status (still blocked upstream on shadone/KDBXKit#6). No new, confirmed, actionable finding. ROADMAP.md's Now/next lane stays fully checked off; the one remaining unchecked item (#77) needs a human, not code. Filing this per routines/executor.prompt.md STEP 6b rather than fabricating make-work. Claude-Session: https://claude.ai/code/session_015cfSymxZiNkz3okWkyYw9w Co-authored-by: Claude <noreply@anthropic.com>
tooming
added a commit
to tooming/keebridge
that referenced
this pull request
Sep 11, 2026
…ill unmerged, backlog empty (#126) STEP 1c: main's CI in_progress, didn't block. STEP 2: zero open PRs. Re-checked shadone/KDBXKit#6 -- still open, unreviewed, no change. Claude-Session: https://claude.ai/code/session_015cfSymxZiNkz3okWkyYw9w Co-authored-by: Claude <noreply@anthropic.com>
tooming
added a commit
to tooming/keebridge
that referenced
this pull request
Sep 11, 2026
…merged, backlog empty (#131) Re-checked shadone/KDBXKit#6 (blocks issue #89) — still open, no reviews, no change since cycle fourteen. Zero open PRs, no new GitHub issue activity. No new, confirmed, actionable finding. Claude-Session: https://claude.ai/code/session_015cfSymxZiNkz3okWkyYw9w Co-authored-by: Claude <noreply@anthropic.com>
tooming
added a commit
to tooming/keebridge
that referenced
this pull request
Sep 11, 2026
…unmerged, backlog empty (#138) Re-checked shadone/KDBXKit#6 — still open, unchanged since cycle nineteen. Read .gitignore in full (fresh angle) — confirmed Package.resolved is deliberately tracked, not ignored, consistent with #89. No inconsistency found. Zero open PRs, no new GitHub issue activity. No new, confirmed, actionable finding. Claude-Session: https://claude.ai/code/session_015cfSymxZiNkz3okWkyYw9w Co-authored-by: Claude <noreply@anthropic.com>
tooming
added a commit
to tooming/keebridge
that referenced
this pull request
Sep 11, 2026
…unmerged, backlog empty (#147) Re-checked shadone/KDBXKit#6 - still open, unchanged for nine cycles now. Zero open PRs, no new GitHub issue activity. No new, confirmed, actionable finding. Claude-Session: https://claude.ai/code/session_015cfSymxZiNkz3okWkyYw9w Co-authored-by: Claude <noreply@anthropic.com>
Author
|
Closing this — going with a downstream workaround in keebridge instead of an upstream dependency change. Thanks for the consideration either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5.
Rationale
Package.swiftcurrently pins swift-crypto withfrom: "3.0.0", which SwiftPM's sugar caps at<4.0.0. This blocks consumers from adopting swift-crypto 4.x. This PR widens the constraint to an explicit range,"3.0.0"..<"5.0.0", allowing both 3.x and 4.x.This unblocks a downstream consumer (tooming/keebridge#89) from moving to swift-crypto 4.x.
CryptoError exhaustiveness check
Per the issue, swift-crypto 4.0.0's only breaking change is new
CryptoErrorcases. I checked whether KDBXKit exhaustively switches overCryptoError(which would break when new cases are added):This returns no matches anywhere in the repository — KDBXKit doesn't reference
CryptoErrorat all, let alone switch over it exhaustively. So this breaking change in 4.0.0 does not affect KDBXKit.Build/test verification
With a local Swift 6.3.2 toolchain:
swift package resolvesucceeds with the widened manifest (kept the existing 3.15.1 pin, sinceresolvedoesn't upgrade on its own).swift package update swift-cryptothen resolves to swift-crypto 4.5.2 (the latest 4.x release) under the new range.swift buildsucceeds fully against swift-crypto 4.5.2.swift testpasses all 473 tests in 73 suites against swift-crypto 4.5.2.Package.resolvedis left untouched in this PR (still pinned to 3.15.1) to keep the change minimal — bumping the actual resolved version is a separate decision for the maintainer.Scope
Only the swift-crypto dependency line in
Package.swiftis changed; nothing else is touched.🤖 Generated with Claude Code