Skip to content

Widen swift-crypto dependency constraint to allow 4.x - #6

Closed
tooming wants to merge 1 commit into
shadone:developfrom
tooming:widen-swift-crypto-constraint
Closed

tooming wants to merge 1 commit into
shadone:developfrom
tooming:widen-swift-crypto-constraint

Conversation

@tooming

@tooming tooming commented Sep 9, 2026

Copy link
Copy Markdown

Fixes #5.

Rationale

Package.swift currently pins swift-crypto with from: "3.0.0", which SwiftPM's sugar caps at <4.0.0. This blocks consumers from adopting swift-crypto 4.x. This PR widens the constraint to an explicit range, "3.0.0"..<"5.0.0", allowing both 3.x and 4.x.

This unblocks a downstream consumer (tooming/keebridge#89) from moving to swift-crypto 4.x.

CryptoError exhaustiveness check

Per the issue, swift-crypto 4.0.0's only breaking change is new CryptoError cases. I checked whether KDBXKit exhaustively switches over CryptoError (which would break when new cases are added):

grep -rn "CryptoError" .

This returns no matches anywhere in the repository — KDBXKit doesn't reference CryptoError at all, let alone switch over it exhaustively. So this breaking change in 4.0.0 does not affect KDBXKit.

Build/test verification

With a local Swift 6.3.2 toolchain:

  • swift package resolve succeeds with the widened manifest (kept the existing 3.15.1 pin, since resolve doesn't upgrade on its own).
  • swift package update swift-crypto then resolves to swift-crypto 4.5.2 (the latest 4.x release) under the new range.
  • swift build succeeds fully against swift-crypto 4.5.2.
  • swift test passes all 473 tests in 73 suites against swift-crypto 4.5.2.

Package.resolved is left untouched in this PR (still pinned to 3.15.1) to keep the change minimal — bumping the actual resolved version is a separate decision for the maintainer.

Scope

Only the swift-crypto dependency line in Package.swift is changed; nothing else is touched.

🤖 Generated with Claude Code

Fixes shadone#5

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
tooming added a commit to tooming/keebridge that referenced this pull request Sep 11, 2026
…ew (#112)

Fresh audit angles this cycle: three previously-unaudited small app-layer
files (ContentView.swift, KeeBridgeApp.swift, LockedView.swift),
KeychainStore.swift, KeeBridgeConfig.swift, VaultReadableContent.swift
(full reads), a full three-target project.yml-vs.-physical-file diff, a
re-read of .github/workflows/ci.yml, and a re-check of issue #89's status
(still blocked upstream on shadone/KDBXKit#6). No new, confirmed,
actionable finding. ROADMAP.md's Now/next lane stays fully checked off;
the one remaining unchecked item (#77) needs a human, not code. Filing
this per routines/executor.prompt.md STEP 6b rather than fabricating
make-work.


Claude-Session: https://claude.ai/code/session_015cfSymxZiNkz3okWkyYw9w

Co-authored-by: Claude <noreply@anthropic.com>
tooming added a commit to tooming/keebridge that referenced this pull request Sep 11, 2026
…ill unmerged, backlog empty (#126)

STEP 1c: main's CI in_progress, didn't block. STEP 2: zero open PRs.
Re-checked shadone/KDBXKit#6 -- still open, unreviewed, no change.


Claude-Session: https://claude.ai/code/session_015cfSymxZiNkz3okWkyYw9w

Co-authored-by: Claude <noreply@anthropic.com>
tooming added a commit to tooming/keebridge that referenced this pull request Sep 11, 2026
…merged, backlog empty (#131)

Re-checked shadone/KDBXKit#6 (blocks issue #89) — still open, no
reviews, no change since cycle fourteen. Zero open PRs, no new
GitHub issue activity. No new, confirmed, actionable finding.


Claude-Session: https://claude.ai/code/session_015cfSymxZiNkz3okWkyYw9w

Co-authored-by: Claude <noreply@anthropic.com>
tooming added a commit to tooming/keebridge that referenced this pull request Sep 11, 2026
…unmerged, backlog empty (#138)

Re-checked shadone/KDBXKit#6 — still open, unchanged since cycle
nineteen. Read .gitignore in full (fresh angle) — confirmed
Package.resolved is deliberately tracked, not ignored, consistent
with #89. No inconsistency found. Zero open PRs, no new GitHub issue
activity. No new, confirmed, actionable finding.


Claude-Session: https://claude.ai/code/session_015cfSymxZiNkz3okWkyYw9w

Co-authored-by: Claude <noreply@anthropic.com>
tooming added a commit to tooming/keebridge that referenced this pull request Sep 11, 2026
…unmerged, backlog empty (#147)

Re-checked shadone/KDBXKit#6 - still open, unchanged for nine cycles
now. Zero open PRs, no new GitHub issue activity. No new, confirmed,
actionable finding.


Claude-Session: https://claude.ai/code/session_015cfSymxZiNkz3okWkyYw9w

Co-authored-by: Claude <noreply@anthropic.com>
@tooming

tooming commented Sep 12, 2026

Copy link
Copy Markdown
Author

Closing this — going with a downstream workaround in keebridge instead of an upstream dependency change. Thanks for the consideration either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Widen swift-crypto dependency constraint to allow 4.x

1 participant