-
Notifications
You must be signed in to change notification settings - Fork 246
feat(configs): add Qwen3.5-4B DFlash draft config and training example for Ascend NPU #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
curnane-lab
wants to merge
1
commit into
sgl-project:main
Choose a base branch
from
curnane-lab:feat/add-qwen3.5-4b-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+89
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| { | ||
| "architectures": [ | ||
| "DFlashDraftModel" | ||
| ], | ||
| "attention_bias": false, | ||
| "attention_dropout": 0.0, | ||
| "auto_map": { | ||
| "AutoModel": "dflash.DFlashDraftModel" | ||
| }, | ||
| "block_size": 16, | ||
| "bos_token_id": 248043, | ||
| "dflash_config": { | ||
| "mask_token_id": 248070, | ||
| "target_layer_ids": [1, 8, 15, 22, 29] | ||
| }, | ||
| "dtype": "bfloat16", | ||
| "eos_token_id": 248044, | ||
| "head_dim": 128, | ||
| "hidden_act": "silu", | ||
| "hidden_size": 2560, | ||
| "initializer_range": 0.02, | ||
| "intermediate_size": 9728, | ||
| "layer_types": [ | ||
| "full_attention", | ||
| "full_attention", | ||
| "full_attention", | ||
| "full_attention", | ||
| "full_attention" | ||
| ], | ||
| "max_position_embeddings": 262144, | ||
| "max_window_layers": 5, | ||
| "model_type": "qwen3", | ||
| "num_attention_heads": 32, | ||
| "num_hidden_layers": 5, | ||
| "num_key_value_heads": 8, | ||
| "num_target_layers": 32, | ||
| "pad_token_id": 248044, | ||
| "rms_norm_eps": 1e-06, | ||
| "rope_scaling": null, | ||
| "rope_theta": 10000000, | ||
| "sliding_window": null, | ||
| "tie_word_embeddings": true, | ||
| "transformers_version": "4.57.1", | ||
| "use_cache": true, | ||
| "use_sliding_window": false, | ||
| "vocab_size": 248320 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| #!/bin/bash | ||
|
|
||
| SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) | ||
| ROOT_DIR=$(dirname $SCRIPT_DIR) | ||
|
|
||
| # Train DFlash for Qwen3.5-4B | ||
| TP_SIZE=1 | ||
| BUILD_DATASET_NUM_PROC=64 | ||
|
|
||
| export HF_DATASETS_CACHE=$ROOT_DIR/cache/hf_datasets | ||
| export TORCHINDUCTOR_CACHE_DIR=$ROOT_DIR/cache/compiled_kernels | ||
|
|
||
| ATTENTION_BACKEND=${2:-flex_attention} | ||
| NUM_GPUS=${1:-8} | ||
|
|
||
| torchrun \ | ||
| --standalone \ | ||
| --nproc_per_node $NUM_GPUS \ | ||
| $ROOT_DIR/scripts/train_dflash.py \ | ||
| --target-model-path PATH/TO/Qwen3.5-4B \ | ||
| --draft-config-path $ROOT_DIR/configs/qwen3.5-4b-dflash.json \ | ||
| --train-data-path $ROOT_DIR/cache/dataset/train_regen.jsonl \ | ||
| --output-dir $ROOT_DIR/outputs/qwen3.5-4b-dflash \ | ||
| --num-epochs 10 \ | ||
| --batch-size 2 \ | ||
| --accumulation-steps 4 \ | ||
| --learning-rate 6e-4 \ | ||
| --warmup-ratio 0.04 \ | ||
| --max-grad-norm 1.0 \ | ||
| --max-length 3072 \ | ||
| --chat-template qwen3.5 \ | ||
| --attention-backend $ATTENTION_BACKEND \ | ||
| --num-anchors 512 \ | ||
| --loss-decay-gamma 7.0 \ | ||
| --log-interval 50 \ | ||
| --save-interval 10000 \ | ||
| --report-to tensorboard \ | ||
| --target-model-backend hf \ | ||
| --tp-size $TP_SIZE \ | ||
| --build-dataset-num-proc $BUILD_DATASET_NUM_PROC \ | ||
| --block-size 16 \ | ||
| --trust-remote-code | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variables
TP_SIZEandBUILD_DATASET_NUM_PROCare defined but not passed to thetrain_dflash.pyscript. They should be included in thetorchruncommand to ensure the configuration is correctly applied during training.torchrun \ --standalone \ --nproc_per_node $NUM_GPUS \ $ROOT_DIR/scripts/train_dflash.py \ --target-model-path PATH/TO/Qwen3.5-4B \ --draft-config-path $ROOT_DIR/configs/qwen3.5-4b-dflash.json \ --train-data-path $ROOT_DIR/cache/dataset/train_regen.jsonl \ --output-dir $ROOT_DIR/outputs/qwen3.5-4b-dflash \ --num-epochs 10 \ --batch-size 2 \ --accumulation-steps 4 \ --learning-rate 6e-4 \ --warmup-ratio 0.04 \ --max-grad-norm 1.0 \ --max-length 3072 \ --chat-template qwen3.5 \ --attention-backend $ATTENTION_BACKEND \ --num-anchors 512 \ --loss-decay-gamma 7.0 \ --log-interval 50 \ --save-interval 10000 \ --report-to tensorboard \ --target-model-backend hf \ --tp-size $TP_SIZE \ --build-dataset-num-proc $BUILD_DATASET_NUM_PROC \ --block-size 16 \ --trust-remote-code