Skip to content

feat(acquire): name the station-selection release, and file v0.4.0 as shipped - #46

Merged
sgjholt merged 2 commits into
mainfrom
claude/roadmap-priorities-pe63kc
Sep 19, 2026
Merged

sgjholt merged 2 commits into
mainfrom
claude/roadmap-priorities-pe63kc

Conversation

@sgjholt

@sgjholt sgjholt commented Sep 18, 2026 •

Copy link
Copy Markdown
Owner

Important

Merge this with a merge commit. Do not squash. Squashing is what broke the last one: it replaces both subjects with the pull request title, and a merge commit keeps them so release-please sees feat(acquire): and docs(roadmap): as separate entries. A squash still produces the right version — the Release-As: 0.5.0 footer survives into the body — but collapses the two changelog lines into one.

Two commits. One restores a release record that a squash destroyed; the other files v0.4.0 on the roadmap.

1. feat(acquire): — the release record, and the docs it owed

#45 was squash-merged, which replaced fix(acquire): ask for waveforms by name… and feat(acquire): rank co-sited instruments… with the PR title. release-please could not parse it:

commit could not be parsed: 2af57e8 Make the station selection mean what the
  config says: radius, and one instrument per station (#45)
error message: Error: unexpected token ' ' at 1:5, valid tokens [(, !, :]
commits: 0
✔ Considering: 0 commits
✔ No commits for path: ., skipping

So the station-selection work is invisible to the release machinery: no bump, and no changelog entry for a release that ships it. The message on main cannot be repaired in place, so the record is restored here where release-please reads it, with Release-As: 0.5.0 pinning the version rather than leaving it to the type.

0.5.0, not 0.4.1 — feat(acquire): rank co-sited instruments is a feature, and with bump-minor-pre-major: true and bump-patch-for-minor-pre-major: false a feature bumps the minor while on 0.x.

The commit carries the documentation that change owed regardless. docs/upgrading.md had no entry for:

  • a radius that now cuts against true WGS84 distance instead of a fixed 111.195 km/degree, which can select a different set of stations for the same config;
  • min_radius_km beginning to work on its own, having previously been sent only alongside max_radius_km;
  • max_radius_km = 0, a negative radius and an inverted annulus now raising instead of silently selecting nothing;
  • channel_priorities / location_priorities.

It was also missing for 0.3 → 0.4, where [smoothing] method began being applied — the same shape of break, where the call is unchanged and the numbers move. That section is added too.

2. docs(roadmap): — v0.4.0 filed as shipped

The roadmap had no v0.4.0 section a day after v0.4.0 released, and its closing paragraph still said nothing was merged and unreleased while the acquire fixes sat on main.

TestTheRoadmapKeepsUpWithTheReleases compares the page against the second-newest minor in CHANGELOG.md, because the newest is release-please's proposal rather than something a reader can install. That deliberate lag is what stops the check blocking its own release PR — and it also means the missing v0.4 section would have gone unnoticed until v0.5 shipped, then failed on main. Verified by injecting a simulated ## [0.5.0] section: 19 passed with this change.

The 1.0 criterion is updated too, since a release has now gone past it. v0.4.0 moved no name and no signature, but [smoothing] method changed what it does, so a config setting konno_ohmachi or none gets different numbers from the same call. That is a weaker promise than 1.0 makes and still one that was broken, so the page counts it rather than claiming a clean release. Worth a second opinion — it is a judgement about your release, not a fact I can check.

Verification

pytest tests/test_release_config.py tests/test_api_surface.py   99 passed, 14 skipped
  test_release_config with a simulated 0.5.0 in CHANGELOG.md    19 passed
sphinx-build                                                    clean (bar blocked intersphinx here)

Docs only — no source file changes in either commit.

🤖 Generated with Claude Code

The page had no v0.4.0 section a day after v0.4.0 released, and said in its
closing paragraph that nothing was merged and unreleased while the acquire
fixes sat on main. Both are the staleness `TestTheRoadmapKeepsUpWithTheReleases`
exists to catch, and it catches the first one late by design: it compares
against the second-newest minor in the changelog, because the newest is
release-please's proposal rather than something a reader can install. So the
v0.4 section is only required once v0.5 ships, and the check would have failed
on main at that moment. Verified by injecting a simulated 0.5.0 release
section: 19 passed with this change, against the failure it produces without.

The 1.0 criterion needed the same update, since a release has gone past it.
v0.4.0 moved no name and no signature, but `[smoothing] method` changed what it
does, so a config setting `konno_ohmachi` or `none` gets different numbers from
the same call. That is a weaker promise than 1.0 makes and still one that was
broken, so the page counts it rather than claiming a clean release.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@sgjholt
sgjholt marked this pull request as ready for review September 18, 2026 13:43
@read-the-docs-community

read-the-docs-community Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 SpecMod | 🛠️ Build #34635876 | 📁 Comparing b460d19 against latest (2af57e8)

  🔍 Preview build  

3 files changed
± roadmap.html
± upgrading.html
± tutorial/specmod-tutorial.html

@sgjholt sgjholt changed the title Roadmap: file v0.4.0 as shipped, and the acquire work as merged docs(roadmap): file v0.4.0 as shipped, and the acquire work as merged Sep 18, 2026
…ersion

The code shipped in 2af57e8, the squash merge of #45. Squashing replaced the
two commit subjects — `fix(acquire): ask for waveforms by name, so the radius
applies to them too` and `feat(acquire): rank co-sited instruments, and cut the
radius in kilometres` — with the pull request's title, which is not a
conventional commit. release-please could not parse it:

    commit could not be parsed: 2af57e8 Make the station selection mean what
      the config says: radius, and one instrument per station (#45)
    error message: Error: unexpected token ' ' at 1:5
    Considering: 0 commits
    No commits for path: ., skipping

So the work is invisible to the release machinery: no bump, and no changelog
entry for a release that contains it. That is the failure `AGENTS.md` means by
load-bearing commit messages, and it cannot be repaired in the commit itself —
the message on `main` is what it is.

This restores the record where release-please will read it, and pays the
documentation the change owed either way: `docs/upgrading.md` had no entry for
a radius that now cuts against WGS84 rather than a fixed 111.195 km/degree, for
`min_radius_km` beginning to work on its own, for the three config errors that
now raise, or for the new priority lists. The same section was missing for
0.3 to 0.4, where `[smoothing] method` began being applied — the same shape of
break, where the call is unchanged and the numbers move.

`Release-As` pins the version rather than leaving it to the type, so the bump
is right whichever way this lands: squashed, the subject is the title of this
pull request and the footer still parses.

Release-As: 0.5.0

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@sgjholt sgjholt changed the title docs(roadmap): file v0.4.0 as shipped, and the acquire work as merged feat(acquire): name the station-selection release, and file v0.4.0 as shipped Sep 18, 2026
@sgjholt
sgjholt merged commit 5247ad9 into main Sep 19, 2026
14 checks passed
@sgjholt
sgjholt deleted the claude/roadmap-priorities-pe63kc branch September 19, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants