Repository navigation
Unblock the release: compare the roadmap against the published minor, not the proposed one - #44
Merged
Merged
Conversation
…roposed one `test_the_roadmap_is_not_behind_the_released_minor` read the version from `.release-please-manifest.json`, which the release pull request bumps as part of preparing a release. On #43 that made the manifest say 0.4.0 while the roadmap's newest section said 0.3.0, and the test failed — on the release pull request itself, in six of the thirteen jobs. The demand was circular. The roadmap documents shipped work, nothing has shipped until the release merges, and the check required the page to name the version before it could honestly do so. Every minor release was unmergeable until someone hand-edited the roadmap into release-please's own branch. It now reads the released versions from `CHANGELOG.md` and compares against the second-newest minor: the newest is whatever the open release pull request proposes, the one before it is what a reader could already have installed. Verified in both directions against the real #43 tree: 19 passed where one failed, and with a 0.5.0 section prepended — the original staleness, one release on — it fails again. The cost is that a stale page is caught one release after it goes stale rather than immediately, which the docstring and the failure message both say. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the six failing jobs on #43.
What broke
test_the_roadmap_is_not_behind_the_released_minor, added in #42, read the version from.release-please-manifest.json. release-please bumps that file as part of preparing a release, so on #43 the manifest says0.4.0while the roadmap's newest section says v0.3.0, and the assertion fails:That took out
teston all five matrix entries,floors, and thecigate with them.lint,typecheck,docs,buildandnotebookwere unaffected.The demand was circular rather than merely mistimed. The roadmap documents shipped work; nothing has shipped until the release pull request merges; the check required the page to name the version before it could honestly do so. Every minor release was unmergeable until someone hand-edited the roadmap into release-please's own branch.
The fix
The released versions now come from
CHANGELOG.md, and the comparison is against the second-newest minor: the newest is whatever the open release pull request proposes, and the one before it is what a reader could already have installed.Verified in both directions against the real #43 tree:
0.4.0, changelog carrying0.4.0, roadmap at v0.3.0 — 19 passed, where one failed before;0.5.0section prepended, which is the original staleness one release on — fails again, naming the published minor.The cost is that a stale page is caught one release after it goes stale rather than immediately. The docstring and the failure message both say so.
After this merges
#43 re-runs and should go green, and 0.4.0 can ship. The roadmap then owes a
## Shipped in v0.4.0section for the smoothing work — a follow-up once the release is actually out, which is the order the page's own rule asks for.Verification
🤖 Generated with Claude Code