fix(tabs): give a maximized tab only the strip above it - #827
Merged
Merged
Conversation
#826 stretched each tab's wrapper over the full bar height, so both the strip above the tab and the one below it picked the tab. Only the top strip is the screen edge #823 was about. The bottom strip is mid-screen, gained nothing from the change, and lost its use as a place to grab the maximized window. The wrapper now reaches from the screen edge down to the tab's bottom, and the strip below the tab is drag region again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #826 (#823).
#826 stretched each tab's wrapper to the full 36px bar height, so the 4px strip below a tab also started picking the tab. Only the top strip is the screen edge #823 is about. The bottom strip is mid-screen. Converting it gained nothing and took away a place to grab the maximized window, for example to drag it down to restore or snap it.
The maximized wrapper now uses
align-self: flex-startwithpadding-top: 4px. It spans from the screen edge to the tab's bottom, and the tab stays where it was.Measured in the dev frontend under a Tauri stub reporting Windows, by hit-testing
elementFromPointdown the bar:npm test1034 pass,vitest445 pass,npm run check0 errors. Not run on real Windows or Linux.