fix(editor): give Mod+Shift+K back to Delete Line - #825
Merged
Merged
Conversation
#652 removed Monaco's Delete Line key because the old Mod+K Shift+R (Delete Row) chord sat one slip away from it. That chord and the whole Mod+K namespace are gone, so the removal guarded nothing, and users coming from VS Code expect the key (#821). Restored on every platform: Cmd+Shift+K on macOS, Ctrl+Shift+K elsewhere. The test now asserts the removal rule stays out; chord ownership is still covered by monacoChordOwnership.spec.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #821, reported by @salvapinyol.
#652 removed Monaco's default
Mod+Shift+K(editor.action.deleteLines) with a--prefixed keybinding rule. The hazard it guarded against wasMod+K Shift+R(Delete Row) sitting one slip away. That chord and the wholeMod+Knamespace went away in the same PR, so the rule no longer protected anything. This drops the rule, so the key works again on every platform: Cmd+Shift+K on macOS, Ctrl+Shift+K elsewhere.The old test asserted the removal. It now asserts
Editor.sveltecarries no-editor.action.deleteLinesrule. Putting the rule back turns it red. Nothing of ours claiming the chord is still caught bymonacoChordOwnership.spec.ts.npm test1034 pass,vitest445 pass,npm run check0 errors. Not tried by hand on Windows or Linux.