Repository navigation
Default type generation to PGlite and clean up the temporary gateway - #87
Open
woahwhattheheck wants to merge 1 commit into
Open
woahwhattheheck wants to merge 1 commit into
woahwhattheheck wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
bun run db:generatecurrently requires an external PostgreSQL service unless PGlite is selected explicitly. This makes the existing embedded migration path the CLI and library default, with--no-pgliteandpglite: falseavailable for generating from an external database.The temporary gateway binds to loopback and restores
DATABASE_URL, closes client sockets and the listener, and closes PGlite even when generation fails. The CLI now initializes the Yargs factory correctly and awaits generation errors. README guidance explains the migration-based default.Regression coverage executes the default package-script command and direct API against an unreachable
DATABASE_URL, checks the generated types and SQL, and exercises failed-output cleanup.Validation on the submitted head
e6245173da35822f74c788dfe8aecea674c4c295with Bun 1.4.2 on Linux:bun install --frozen-lockfile: passed.bun test: 6 passed, 0 failed.bun run build: passed, including declaration generation.bun run format:checkandgit diff --check: passed.Fixes #2
/claim #2