Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialized projects currently run
pgstrap generatefordb:generate, so the command still connects to external PostgreSQL despite the existing PGlite option. This change makes the generated script usepgstrap generate --pglite; the ordinary CLI defaults and external database workflow stay available.Adds an integration regression that initializes a project, writes a migration, and executes its actual
bun run db:generatescript through a bundled CLI. A rejecting local endpoint stands in for the configured external database. The unfixed script attempts one external connection and fails; the repaired script makes zero external connections and generates the expected widget types and SQL. README guidance and the existing initialization expectation are updated.The existing PGlite adapter submits migration queries one statement at a time. A raw
pgm.sql(...)string containing multiple commands must be split into separate calls or run through the external PostgreSQL workflow; this change documents that existing limitation and leaves the adapter unchanged.Validation on Windows with Bun 1.4.2:
bun test: 4 passed, 0 failed.bun run build: passed.bun run format:check: passed.git diff --cached --check: passed.Fixes #2
@algora-pbc /claim #2