Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
db:generatenow runs migrations in PGlite by default, so it can generate schema types and SQL without a PostgreSQL server.--no-pglitestill selects the configured PostgreSQL database, and the directgenerate()API keeps its existing default.127.0.0.1.DATABASE_URL.Verification
I ran the actual bundled CLI on Windows with Node. With the original configuration loader it failed with
ERR_UNSUPPORTED_ESM_URL_SCHEME; with the loader fixed and the previous CLI default it tried the unreachable PostgreSQL address. The final default generated both the type file and SQL dump containing the migrated table.--no-pgliteselected the external database as expected. All eight checks passed. Biome andgit diff --checkpassed.The Bun test runner was unavailable locally, so the new Bun regression test has not been run locally.
Fixes #2
@algora-pbc /claim #2