Repository navigation
fix: one Bolt connection per thread, not one per pool - #90
Merged
Merged
Conversation
The pool handed one adapter to every thread and only guarded creation, so concurrent queries interleaved on a single Bolt socket and corrupted the stream. Connections are now per thread, tracked for disconnect, and dead threads' sockets are reaped and closed. Also adds ConstraintError and TransientError, mapped from server error codes for both Neo4j and Memgraph.
Memgraph answers write/write conflicts with a TransientError that means "try again". Auto-commit queries now retry up to 3 times with full jitter. Explicit transactions are not retried: the caller owns those and earlier statements may already have applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.