Repository navigation
fix: repair broken has_one/belongs_to/through associations - #87
Merged
Merged
Conversation
Contributor
|
By eye it looks good to me, I like all the extracted utility functions! If it ends up causing problems I'm happy to help write tests. |
Owner
Author
|
They are already tested. I added test/relationships/singular_and_through_associations_test.rb , that the bug i found while refactoring. I will fix some tests tomorrow and release a version. |
…pers Associations called phantom .where/.rel/.to on Pattern::Node and never worked. Rewrite on the real Pattern/Query API, fix :through declaration, add coverage. Extract shared helpers across cyrel + adapters.
seuros
force-pushed
the
fix/associations-and-dedup
branch
from
June 26, 2026 09:13
ee7e79e to
89f1cdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associations called phantom .where/.rel/.to on Pattern::Node and never worked. Rewrite on the real Pattern/Query API, fix :through declaration, add coverage. Extract shared helpers across cyrel + adapters.
ping @metkat
Can you review test this on your end. I moved files around to remove the logic/helper duplication.