Repository navigation
Fix the unit test that turned CI red on main - #51
Merged
Merged
Conversation
inspect() rejects files under 100 bytes before it reads the header. The test was writing 36 bytes and then expecting the header error, which is why main went red. Co-authored-by: Cursor <cursoragent@cursor.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RoomDbFiles.inspect()treats anything under 100 bytes as “too small” and never looks at the SQLite header.non sqlite header is rejectedtest wrote 36 bytes of text, then asserted the header error (Not a SQLite file). That mismatch is what failedtestDebugUnitTeston main.Test plan
testDebugUnitTeston this PR to go green./gradlew :app:testDebugUnitTest --tests com.app.paperstow.data.backup.RoomDbFilesTestMade with Cursor