Update to Unicode 17 #144
Merged
Merged
Conversation
Member
|
We should not be hardcoding the BN values. We should probably try to consume DerivedBidiClass.txt instead. |
Member
|
I'd recommend splitting this into two PRs: one to update to 17, which I can merge first, and then one based on it that tries to fix the BN issue. |
asibahi
force-pushed
the
push-rmwkxtwnmxon
branch
from
October 13, 2025 19:38
d4f2eb9 to
67c0218
Compare
Contributor
Author
|
Made this only about unicode 17. |
Contributor
Author
I don't know Python. It is ok if I do it using the soon-to-be-stablized cargo scripts feature? |
Member
|
Please no, we don't want to maintain multiple scripts here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated tests and all tests pass.
From
DerivedBidiClass.txt:Unsure what to do about
Default_Ignorable_Code_Point. Many of them a Clsss already, and they don't fall in "neat" ranges.Could generate.py move into parsing DerivedBidiClass instead of UnicodeData?
Addressed #143 .