Skip to content

Update to Unicode 17 #144

Merged
Manishearth merged 1 commit into
servo:mainfrom
asibahi:push-rmwkxtwnmxon
Oct 13, 2025
Merged

Update to Unicode 17 #144
Manishearth merged 1 commit into
servo:mainfrom
asibahi:push-rmwkxtwnmxon

Conversation

@asibahi

@asibahi asibahi commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

Updated tests and all tests pass.

From DerivedBidiClass.txt:

# The unassigned code points that default to BN have one of the following properties:
#     Default_Ignorable_Code_Point
#     Noncharacter_Code_Point

Unsure what to do about Default_Ignorable_Code_Point. Many of them a Clsss already, and they don't fall in "neat" ranges.

Could generate.py move into parsing DerivedBidiClass instead of UnicodeData?

Addressed #143 .

@asibahi asibahi changed the title Update to Unicode 17 and fix noncharacters classification and texts. Update to Unicode 17 and fix noncharacters classification and tests. Oct 13, 2025
@Manishearth

Copy link
Copy Markdown
Member

We should not be hardcoding the BN values. We should probably try to consume DerivedBidiClass.txt instead.

@Manishearth

Copy link
Copy Markdown
Member

I'd recommend splitting this into two PRs: one to update to 17, which I can merge first, and then one based on it that tries to fix the BN issue.

@asibahi asibahi changed the title Update to Unicode 17 and fix noncharacters classification and tests. Update to Unicode 17 Oct 13, 2025
@asibahi

asibahi commented Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

Made this only about unicode 17.

@Manishearth
Manishearth merged commit 3bf3403 into servo:main Oct 13, 2025
7 checks passed
@asibahi

asibahi commented Nov 9, 2025

Copy link
Copy Markdown
Contributor Author

I'd recommend splitting this into two PRs: one to update to 17, which I can merge first, and then one based on it that tries to fix the BN issue.

I don't know Python. It is ok if I do it using the soon-to-be-stablized cargo scripts feature?

@Manishearth

Copy link
Copy Markdown
Member

Please no, we don't want to maintain multiple scripts here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants