fix percent-encode of caret in path (#1140)#1141
Merged
Manishearth merged 1 commit intoJul 8, 2026
Merged
Conversation
Manishearth
approved these changes
Jul 8, 2026
Contributor
Author
|
I'm not sure how the test suite is handled here, but there's definitely an entry in the web-platform-tests repo for the path percent-encode set: |
Member
|
Ah, there we go, there is an unexpected success in the CI. Just modify https://github.com/servo/rust-url/blob/main/url/tests/expected_failures.txt and check locally with |
This commit adds the caret symbol U+005E (`^`) to the path percent-encode set, as required by the WHATWG spec. This fixes percent-encoding of carets in the path during parsing. This commit adds a test for all URL codepoints that are part of the path percent-encode set, except for `?` and `#` which end parsing of the path. Closes servo#1140
demurgos
force-pushed
the
fix/issue-1140-caret-path-percent-encode-set
branch
from
e1934bb to
2faa81d
Compare
Contributor
Author
|
Done, I've also found it at the moment. This explains how it was missed: it was marked as an expected failure. Could you please approve the workflow? |
Manishearth
approved these changes
Jul 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
=======================================
Coverage ? 86.94%
=======================================
Files ? 26
Lines ? 5276
Branches ? 0
=======================================
Hits ? 4587
Misses ? 689
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the caret symbol U+005E (
^) to the path percent-encode set, as required by the WHATWG spec. This fixes percent-encoding of carets in the path during parsing.This commit adds a test for all URL codepoints that are part of the path percent-encode set, except for
?and#which end parsing of the path.Closes #1140