Fetch PR branch in semver-check workflow#718
Merged
mrobinson merged 1 commit intoservo:mainfrom Jan 19, 2026
Merged
Conversation
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
mrobinson
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The semver CI job is still failing after #715. In https://github.com/servo/html5ever/actions/runs/21148626657/job/60819760648 we can see that the job checks out the remote
maininstead of the PR branch, and then fails to fetchmainagain at a later point. This change explicitly specifiesref: refs/pull/${{ github.event.pull_request.number }}/headon the checkout action which should fix the issue.I've tested this on my fork and it seems to work (successful run is here), though evidently that doesn't mean much.
Note that the job will fail on this PR too, as it uses the workflow definition from
main.