fix: eliminate activation confirmation race#385
Open
davidvornholt wants to merge 1 commit into
Open
Conversation
davidvornholt
marked this pull request as ready for review
July 11, 2026 11:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The activation process previously created the canary before registering its watcher. A fast controller could observe and delete the canary during that gap, leaving the activation process waiting until
confirm_timeoutand then rolling back a deployment that had already been confirmed.Watching the parent directory before exposing the canary removes that gap. It also avoids trying to register a watcher on a file that may already have been deleted.
Validation
cargo test --all-targetscargo clippy --all-targets -- --deny warningscargo fmt --checknix flake check --show-trace