feat: add MockBinding.connect virtual loop cable#56
Open
JSap0914 wants to merge 1 commit into
Open
Conversation
Add a `MockBinding.connect(path1, path2)` static method that wires two mock ports together with a virtual loop cable, like a physical null-modem/loopback cable between two serial ports. Data written to one connected port is delivered to the other port's read buffer (and vice versa) and wakes any pending read on the peer. Data written while the peer is closed is dropped. Includes regression tests covering delivery, bidirectionality, waking a pending peer read, dropped writes when the peer is closed, and validation that both ports exist, plus README documentation. Closes serialport/node-serialport#1580 Signed-off-by: JSup <hanjisang0914@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the "virtual loop cable" feature requested in serialport/node-serialport#1580 (good first issue).
What
Adds a
MockBinding.connect(path1, path2)static method that wires two mock ports together with a virtual loop cable, like a physical null-modem/loopback cable between two serial ports. Data written to one connected port is delivered to the other port's read buffer (and vice versa), instead of being echoed back to the writer.Behavior
echooption).connectthrows if either port has not been created first.Tests
Adds regression tests for delivery, bidirectionality, waking a pending peer read, dropped writes when the peer is closed, and both-ports-exist validation. Full suite (
npm test) passes (12 passing);npm run lintandnpm run buildare clean.Docs
README updated with a "Virtual loop cable" section.
Closes serialport/node-serialport#1580